Re: [PATCH v5 net-next 06/11] net/nebula-matrix: add common resource implementation

[Andrew Lunn <andrew@lunn.ch>]

> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_hw/nbl_hw_leonis/nbl_resource_leonis.c
> @@ -6,7 +6,32 @@
>  
>  #include "nbl_resource_leonis.h"
>  
> +static u16 nbl_res_get_vsi_id(struct nbl_resource_mgt *res_mgt, u16 func_id,
> +			      u16 type)
> +{
> +	return nbl_res_func_id_to_vsi_id(res_mgt, func_id, type);
> +}

> +int nbl_res_func_id_to_pfvfid(struct nbl_resource_mgt *res_mgt, u16 func_id,
> +			      int *pfid, int *vfid)
> +{
> +	return func_id_to_pfvfid(res_mgt, func_id, pfid, vfid);
> +}
> +
> +u16 nbl_res_pfvfid_to_vsi_id(struct nbl_resource_mgt *res_mgt, int pfid,
> +			     int vfid, u16 type)
> +{
> +	return pfvfid_to_vsi_id(res_mgt, pfid, vfid, type);
> +}
> +
> +int nbl_res_func_id_to_bdf(struct nbl_resource_mgt *res_mgt, u16 func_id,
> +			   u8 *bus, u8 *dev, u8 *function)
> +{
> +	return func_id_to_bdf(res_mgt, func_id, bus, dev, function);
> +}
> +
> +int nbl_res_vsi_id_to_pf_id(struct nbl_resource_mgt *res_mgt, u16 vsi_id)
> +{
> +	return vsi_id_to_pf_id(res_mgt, vsi_id);
> +}
> +
> +u16 nbl_res_func_id_to_vsi_id(struct nbl_resource_mgt *res_mgt, u16 func_id,
> +			      u16 type)
> +{
> +	return func_id_to_vsi_id(res_mgt, func_id, type);
> +}


None of these functions actually do anything. Why do they exist?

	Andrew