From: "John W. Linville" <linville@tuxdriver.com>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: jgarzik@pobox.com, shemminger@osdl.org, mlindner@syskonnect.de,
rroesler@syskonnect.de
Subject: [patch 2.6.14-rc4 1/3] sk98lin: remove MODULE_DEVICE_TABLE to avoid conflicts w/ skge
Date: Tue, 18 Oct 2005 21:31:00 -0400 [thread overview]
Message-ID: <10182005213100.12360@bilbo.tuxdriver.com> (raw)
In-Reply-To: <10182005213059.12304@bilbo.tuxdriver.com>
The skge driver claims support for the identical list of hardware
supported by the in-kernel sk98lin driver. This can confuse userland
tools which pick modules based on the PCI ID lists exported through
MODULE_DEVICE_TABLE.
This patch removes the MODULE_DEVICE_TABLE line from sk98lin. The
driver can still be loaded manually if necessary or desireable.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
drivers/net/sk98lin/skge.c | 2 --
1 files changed, 2 deletions(-)
diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c
--- a/drivers/net/sk98lin/skge.c
+++ b/drivers/net/sk98lin/skge.c
@@ -5227,8 +5227,6 @@ static struct pci_device_id skge_pci_tbl
{ 0 }
};
-MODULE_DEVICE_TABLE(pci, skge_pci_tbl);
-
static struct pci_driver skge_driver = {
.name = "sk98lin",
.id_table = skge_pci_tbl,
next prev parent reply other threads:[~2005-10-19 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 1:30 [patch 2.6.14-rc4 0/3] sk98lin: neuter and prepare for removal John W. Linville
2005-10-19 1:31 ` John W. Linville [this message]
2005-10-19 1:31 ` [patch 2.6.14-rc4 2/3] MAINTAINERS: mark the sk98lin driver as obsolete John W. Linville
2005-10-19 1:31 ` [patch 2.6.14-rc4 3/3] Documentation: add sk98lin to the feature-removal-schedule John W. Linville
2005-10-19 1:38 ` [patch 2.6.14-rc4 0/3] sk98lin: neuter and prepare for removal Stephen Hemminger
2005-10-19 1:41 ` John W. Linville
2005-10-19 2:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10182005213100.12360@bilbo.tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
--cc=netdev@vger.kernel.org \
--cc=rroesler@syskonnect.de \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).