netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: jeffrey.t.kirsher@intel.com, "Ramamurthy,
	Harshitha" <harshitha.ramamurthy@intel.com>,
	David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
Date: Thu, 15 Feb 2018 12:38:54 -0600	[thread overview]
Message-ID: <102e09cf-a090-d6c2-8b10-5190644203cc@embeddedor.com> (raw)
In-Reply-To: <1518718272.6698.2.camel@intel.com>



On 02/15/2018 12:11 PM, Jeff Kirsher wrote:
> On Thu, 2018-02-15 at 09:56 -0800, Ramamurthy, Harshitha wrote:
>> On Thu, 2018-02-15 at 11:44 -0600, Gustavo A. R. Silva wrote:
>>> It seems this is a copy-paste error and that the proper variable to
>>> use
>>> in this particular case is _src_ instead of _dst_.
>>>
>>> Addresses-Coverity-ID: 1465282 ("Copy-paste error")
>>> Fixes: 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>>
>> Thanks for the patch!
>>

Glad to help. :)

>> Acked-by:Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> Dave, no need for me to pick this patch up and then push to you.  You
> can circumvent me and pick this up.
> 
>>> ---
>>>   drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks guys.
--
Gustavo

      reply	other threads:[~2018-02-15 18:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 17:44 [PATCH] i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower Gustavo A. R. Silva
2018-02-15 17:56 ` Ramamurthy, Harshitha
2018-02-15 18:11   ` Jeff Kirsher
2018-02-15 18:38     ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=102e09cf-a090-d6c2-8b10-5190644203cc@embeddedor.com \
    --to=garsilva@embeddedor.com \
    --cc=davem@davemloft.net \
    --cc=harshitha.ramamurthy@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).