From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andras Kis-Szabo Subject: Re: [PATCH] IPv6: Functions Clean-up Date: Sun, 03 Nov 2002 15:27:42 +0100 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: <1036333662.12980.27.camel@arwen> References: <20021103.115427.104445233.yoshfuji@linux-ipv6.org> <1036328414.1048.3.camel@arwen> <20021103.221658.52523847.yoshfuji@linux-ipv6.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7BIT Cc: linux-kernel@vger.kernel.org, Netdev , Netfilter Devel , "David S. Miller" , kuznet@ms2.inr.ac.ru, usagi@linux-ipv6.org Return-path: In-reply-to: <20021103.221658.52523847.yoshfuji@linux-ipv6.org> To: YOSHIFUJI Hideaki / =?UTF-8?Q?=E5=90=89=E8=97=A4=E8=8B=B1?= =?UTF-8?Q?=E6=98=8E?= Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netdev.vger.kernel.org Hi, > /* > * Taken from net/ipv6/ip6_output.c > * We should use the one there, but is defined static > * so we put this just here and let the things as > * they are now. > * > * If that one is modified, this one should be modified too. > */ > > So, the reason why the copy of route6_me_harder() > lives there is because net/ipv6/ip6_output.c has not been > exported it. Ok, ok! I have not got problems with this any more! :) It is even worse that the route6_me_harder() depends on the CONFIG_NETFILTER option, so this function comes from the Netfilter. In this case it is an unwanted code-duplication :( > Is this something to do with parser of extension headers? > Parser of extension headers is different thing, isn't it? Yes, it is a different thing with different code. Regards, kisza -- Andras Kis-Szabo Security Development, Design and Audit -------------------------/ Zorp, NetFilter and IPv6 kisza@SecurityAudit.hu /------------------------------------------->