* [PATCH net] ibmvnic: Return failure on attempted mtu change
@ 2017-06-06 21:55 John Allen
2017-06-07 19:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: John Allen @ 2017-06-06 21:55 UTC (permalink / raw)
To: netdev; +Cc: Thomas Falcon, Nathan Fontenot, John Allen
Changing the mtu is currently not supported in the ibmvnic driver.
Implement .ndo_change_mtu in the driver so that attempting to use ifconfig
to change the mtu will fail and present the user with an error message.
Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
---
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 4f2d329..8ff6c74 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1468,6 +1468,11 @@ static void ibmvnic_netpoll_controller(struct net_device *dev)
}
#endif
+static int ibmvnic_change_mtu(struct net_device *netdev, int new_mtu)
+{
+ return -EOPNOTSUPP;
+}
+
static const struct net_device_ops ibmvnic_netdev_ops = {
.ndo_open = ibmvnic_open,
.ndo_stop = ibmvnic_close,
@@ -1479,6 +1484,7 @@ static void ibmvnic_netpoll_controller(struct net_device *dev)
#ifdef CONFIG_NET_POLL_CONTROLLER
.ndo_poll_controller = ibmvnic_netpoll_controller,
#endif
+ .ndo_change_mtu = ibmvnic_change_mtu,
};
/* ethtool functions */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ibmvnic: Return failure on attempted mtu change
2017-06-06 21:55 [PATCH net] ibmvnic: Return failure on attempted mtu change John Allen
@ 2017-06-07 19:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-06-07 19:03 UTC (permalink / raw)
To: jallen; +Cc: netdev, tlfalcon, nfont
From: John Allen <jallen@linux.vnet.ibm.com>
Date: Tue, 6 Jun 2017 16:55:52 -0500
> Changing the mtu is currently not supported in the ibmvnic driver.
>
> Implement .ndo_change_mtu in the driver so that attempting to use ifconfig
> to change the mtu will fail and present the user with an error message.
>
> Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-07 19:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-06 21:55 [PATCH net] ibmvnic: Return failure on attempted mtu change John Allen
2017-06-07 19:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).