netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Smith <markzzzsmith@ozemail.com.au>
To: Mark Smith <markzzzsmith@ozemail.com.au>
Cc: thockin@hockin.org, netdev@oss.sgi.com
Subject: [PATCH] 802.3x / ETHTOOL Pause frame support for natsemi.c (netgear fa311/fa312 + ns83816)
Date: 31 Jan 2003 00:25:19 +1030	[thread overview]
Message-ID: <1043934941.848.21.camel@dupy> (raw)
In-Reply-To: <1043583669.1774.22.camel@dupy>

Hi Tim, All,

Isn't it always the way ? Downloaded the new version of the natsemi
NS83815.pdf file (dated Sep 2002), and the message about the 83815 (used
on the Netgear Fa311 / Fa312 cards) not supporting ethernet pause frames
has disappeared.

Looks like a bug in the old doco rather than the hardware.

Here is the updated patch, with the check for the NS83816 chip removed.

It applies to natsemi.c version 1.0.17, which is contained in both
versions 2.4.20 and 2.5.56 of the linux kernel.

I'm hoping other people can help me test it, I'd appreciate bug reports,
suggestions and other constructive criticism.

I've put the patch here 

http://www.nosense.org/natsemi.c.ethpause.1.1.diff

just in case attaching it to my last email was a bit rude (I didn't
think a 5 KB email was too big, my appologies if it was).


Thanks,
Mark.


On Sun, 2003-01-26 at 22:51, Mark Smith wrote:
> Hi Tim, *
> 
> I've put together the following patch to enable 802.3x ethernet pause
> frame support, including the ethtool pause options, on the natsemi 83816
> based network cards.
> 
> I've tested it on my 83815 based Netgear FA312 card, which does have all
> the required registers, but according to page 69 of the NS83815.pdf
> document, the pause feature is not supported. I added the check for
> 83816 chips just as the final step before posting it.
> 
> I haven't done any kernel level programming before, so I'd appreciate
> any suggestions or improvements I can make to it.
> 
> The patch is against natsemi.c version 1.0.17.
> 
> Thanks,
> Mark.
> 

      reply	other threads:[~2003-01-30 13:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-26 12:21 [PATCH][RFT] 802.3x / ETHTOOL Pause frame support for natsemi 83816 Mark Smith
2003-01-30 13:55 ` Mark Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1043934941.848.21.camel@dupy \
    --to=markzzzsmith@ozemail.com.au \
    --cc=netdev@oss.sgi.com \
    --cc=thockin@hockin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).