netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2.{4,x5}.x] mod_timer cleanups for dst.c
@ 2003-05-04  9:25 Vinay K Nallamothu
  2003-05-04 11:26 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Vinay K Nallamothu @ 2003-05-04  9:25 UTC (permalink / raw)
  To: netdev

Hi,

Just reposting what I earlier posted to the linux-kernel mailing list.
These are trivial patches converting {del,add}_timer to mod_timer.

Also kindly let me know whether this is the right platform to post the
PPP & FR related fixes or to linux-x25 mailing list.

vinay

PS: I am not subscribed to this mailing list

--- linux-2.5.68/net/core/dst.c	2003-03-25 10:08:35.000000000 +0530
+++ linux-2.5.68-mod/net/core/dst.c	2003-05-03 13:42:12.000000000 +0530
@@ -154,11 +154,9 @@
 	dst->next = dst_garbage_list;
 	dst_garbage_list = dst;
 	if (dst_gc_timer_inc > DST_GC_INC) {
-		del_timer(&dst_gc_timer);
 		dst_gc_timer_inc = DST_GC_INC;
 		dst_gc_timer_expires = DST_GC_MIN;
-		dst_gc_timer.expires = jiffies + dst_gc_timer_expires;
-		add_timer(&dst_gc_timer);
+		mod_timer(&dst_gc_timer, jiffies + dst_gc_timer_expires);
 	}
 	spin_unlock_bh(&dst_lock);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.{4,x5}.x] mod_timer cleanups for dst.c
  2003-05-04  9:25 [PATCH 2.{4,x5}.x] mod_timer cleanups for dst.c Vinay K Nallamothu
@ 2003-05-04 11:26 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-05-04 11:26 UTC (permalink / raw)
  To: vinay-rc; +Cc: netdev

   From: Vinay K Nallamothu <vinay-rc@naturesoft.net>
   Date: 04 May 2003 14:55:34 +0530

   Just reposting what I earlier posted to the linux-kernel mailing list.
   These are trivial patches converting {del,add}_timer to mod_timer.

Thanks, this is actually a bug fix.  The old code could add_timer()
while the timer was active.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-05-04 11:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-04  9:25 [PATCH 2.{4,x5}.x] mod_timer cleanups for dst.c Vinay K Nallamothu
2003-05-04 11:26 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).