netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <fubar@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: show offload settings
Date: Fri, 15 Aug 2008 15:59:43 -0700	[thread overview]
Message-ID: <10558.1218841183@death.nxdomain.ibm.com> (raw)
In-Reply-To: <20080815.145118.198768799.davem@davemloft.net>

David Miller <davem@davemloft.net> wrote:

>From: Stephen Hemminger <shemminger@vyatta.com>
>Date: Fri, 15 Aug 2008 10:02:59 -0700
>
>> Add more ethtool generic operations to dump the bridge offload
>> settings.
>> 
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
>Applied, thanks.

	I might be confused, but it looks like Stephen included the
wrong patch; it references "bridge" in the comments, but duplicates his
earlier patch for bonding:

Date: 	Fri, 15 Aug 2008 10:02:59 -0700
From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH] bridge: show offload settings
Organization: Vyatta

Add more ethtool generic operations to dump the bridge offload
settings.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/net/bonding/bond_main.c	2008-08-11 11:22:42.000000000 -0700
+++ b/drivers/net/bonding/bond_main.c	2008-08-11 11:26:07.000000000 -0700
@@ -4493,6 +4493,12 @@ static void bond_ethtool_get_drvinfo(str

 static const struct ethtool_ops bond_ethtool_ops = {
 	.get_drvinfo		= bond_ethtool_get_drvinfo,
+	.get_link		= ethtool_op_get_link,
+	.get_tx_csum		= ethtool_op_get_tx_csum,
+	.get_sg			= ethtool_op_get_sg,
+	.get_tso		= ethtool_op_get_tso,
+	.get_ufo		= ethtool_op_get_ufo,
+	.get_flags		= ethtool_op_get_flags,
 };

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com

  reply	other threads:[~2008-08-15 22:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 17:02 [PATCH] bridge: show offload settings Stephen Hemminger
2008-08-15 21:51 ` David Miller
2008-08-15 22:59   ` Jay Vosburgh [this message]
2008-08-15 23:50     ` Stephen Hemminger
2008-08-16  2:46       ` David Miller
2008-08-16  2:56     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10558.1218841183@death.nxdomain.ibm.com \
    --to=fubar@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).