From: Tom St Denis <tstdenis@elliptictech.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Mike Galbraith <bitbucket@online.de>,
Eric Dumazet <erdnetdev@gmail.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
David Miller <davem@davemloft.net>,
steffen klassert <steffen.klassert@secunet.com>,
herbert@gondor.hengli.com.au, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>
Subject: Re: IPsec AH use of ahash
Date: Sun, 20 Jan 2013 12:33:38 -0500 (EST) [thread overview]
Message-ID: <1061016395.93207.1358703218325.JavaMail.root@elliptictech.com> (raw)
In-Reply-To: <50FC2366.1000509@zytor.com>
----- Original Message -----
> From: "H. Peter Anvin" <hpa@zytor.com>
> To: "Tom St Denis" <tstdenis@elliptictech.com>
> Cc: "Mike Galbraith" <bitbucket@online.de>, "Eric Dumazet" <erdnetdev@gmail.com>, "Waskiewicz Jr, Peter P"
> <peter.p.waskiewicz.jr@intel.com>, "David Miller" <davem@davemloft.net>, "steffen klassert"
> <steffen.klassert@secunet.com>, herbert@gondor.hengli.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
> "Michal Kubecek" <mkubecek@suse.cz>
> Sent: Sunday, 20 January, 2013 12:03:34 PM
> Subject: Re: IPsec AH use of ahash
>
> On 01/20/2013 07:07 AM, Tom St Denis wrote:
> >
> > In all likelihood I will submit a revised CMAC patch but it'll take
> > time before I can get business hours to work on it. So instead of
> > having a maintainer just touch it up we're all going to lose out
> > because of pride?
> >
>
> It's not about pride. It is about the fact that maintainers don't
> scale. A single troublesome contributor can easily take up as much
> maintainer time as over a dozen contributors who know how to work
> well
> with their upstream.
Ironically I'd view consistency with existing code as paramount over [say] adherence to some coding standard that none of the code I've seen in the kernel apparently sticks to in the first place. In this case since XCBC and CMAC operate almost identically it made sense to me to copy it as a template. Now you're telling me I have to re-write it... so that now it's different than XCBC? Or are you suggesting that I also re-write XCBC?
Similarly AH4 and AH6 violate the coding standards. Are you suggesting I re-write those entirely as well to merely augment its functionality?
For a project that *boasts* about it's abhorrent lack of commenting/documentation since "the source is the documentation" it's funny that you can't actually READ the source as an authority.
Tom
prev parent reply other threads:[~2013-01-20 17:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <528051367.70594.1358268708738.JavaMail.root@elliptictech.com>
2013-01-16 6:21 ` IPsec AH use of ahash Steffen Klassert
2013-01-18 19:35 ` Tom St Denis
2013-01-18 19:50 ` David Miller
2013-01-18 20:53 ` Tom St Denis
2013-01-18 22:16 ` Waskiewicz Jr, Peter P
2013-01-18 22:31 ` Tom St Denis
2013-01-19 2:33 ` Michal Kubecek
2013-01-19 2:59 ` Tom St Denis
2013-01-19 3:59 ` Eric Dumazet
2013-01-19 10:30 ` Tom St Denis
2013-01-19 15:46 ` Eric Dumazet
2013-01-20 5:06 ` Mike Galbraith
2013-01-20 10:31 ` Borislav Petkov
2013-01-20 12:56 ` Tom St Denis
2013-01-20 13:34 ` Alexander Holler
2013-01-20 13:54 ` Tom St Denis
2013-01-30 22:16 ` Jan Engelhardt
2013-01-20 22:07 ` Steven Rostedt
2013-01-21 0:47 ` Tom St Denis
2013-01-20 12:55 ` Tom St Denis
2013-01-20 14:11 ` Mike Galbraith
2013-01-20 15:07 ` Tom St Denis
2013-01-20 16:34 ` David Dillow
2013-01-20 17:40 ` Tom St Denis
2013-01-20 18:11 ` David Dillow
2013-01-20 18:47 ` Tom St Denis
2013-01-20 22:54 ` Steven Rostedt
2013-01-21 0:34 ` Borislav Petkov
2013-01-21 0:40 ` Tom St Denis
2013-01-21 1:08 ` Borislav Petkov
2013-01-21 9:18 ` David Dillow
2013-01-21 10:20 ` Tom St Denis
2013-01-21 13:38 ` Steven Rostedt
2013-01-21 13:45 ` Tom St Denis
2013-01-21 14:37 ` Steven Rostedt
2013-01-21 14:51 ` Tom St Denis
2013-01-21 15:28 ` Steven Rostedt
2013-01-21 15:31 ` Tom St Denis
2013-01-21 15:49 ` Chris Friesen
2013-01-21 16:05 ` Tom St Denis
2013-01-20 20:30 ` Alan Cox
2013-01-21 0:46 ` Tom St Denis
2013-01-20 17:03 ` H. Peter Anvin
2013-01-20 17:33 ` Tom St Denis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1061016395.93207.1358703218325.JavaMail.root@elliptictech.com \
--to=tstdenis@elliptictech.com \
--cc=bitbucket@online.de \
--cc=davem@davemloft.net \
--cc=erdnetdev@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).