netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martijn Hijdra <martijn@esrac.ele.tue.nl>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-hams@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] hamradio/scc -
Date: Wed, 17 Sep 2003 08:35:41 +0200	[thread overview]
Message-ID: <1063780541.2971.4.camel@imst153.imst.de> (raw)
In-Reply-To: <20030915162335.0034a551.shemminger@osdl.org>

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On Tue, 2003-09-16 at 01:23, Stephen Hemminger wrote:
> Update hamradio/scc for 2.6.0-test5
> 	- use seq_file for /proc
> 	- get rid of dev_get()
> 	- use alloc_netdev
> 

Hi, and another small patch for hamradio/scc to
fill the statistics counters for the scc driver.
(see output of ifconfig RX bytes and TX bytes)



-- 
Martijn Hijdra <martijn@esrac.ele.tue.nl>

[-- Attachment #2: scc_260t5.diff --]
[-- Type: text/x-patch, Size: 1198 bytes --]

--- drivers/net/hamradio/scc.c.orig	2003-08-23 01:58:57.000000000 +0200
+++ drivers/net/hamradio/scc.c	2003-09-03 08:57:50.000000000 +0200
@@ -1635,6 +1635,7 @@
 	}
 		
 	scc->dev_stat.rx_packets++;
+	scc->dev_stat.rx_bytes += skb->len;
 
 	skb->dev      = scc->dev;
 	skb->protocol = htons(ETH_P_AX25);
@@ -1661,6 +1662,7 @@
 	}
 	
 	scc->dev_stat.tx_packets++;
+	scc->dev_stat.tx_bytes += skb->len;
 	scc->stat.txframes++;
 	
 	kisscmd = *skb->data & 0x1f;
--- include/linux/scc.h.orig	2003-09-03 09:13:26.000000000 +0200
+++ include/linux/scc.h	2003-09-03 09:13:55.000000000 +0200
@@ -200,7 +200,7 @@
 	unsigned char fulldup;		/* Full Duplex mode 0=CSMA 1=DUP 2=ALWAYS KEYED */
 	unsigned char waittime;		/* Waittime before any transmit attempt */
 	unsigned int  maxkeyup;		/* Maximum time to transmit (seconds) */
-	unsigned char mintime;		/* Minimal offtime after MAXKEYUP timeout (seconds) */
+	unsigned int  mintime;		/* Minimal offtime after MAXKEYUP timeout (seconds) */
 	unsigned int  idletime;		/* Maximum idle time in ALWAYS KEYED mode (seconds) */
 	unsigned int  maxdefer;		/* Timer for CSMA channel busy limit */
 	unsigned char tx_inhibit;	/* Transmit is not allowed when set */	

      parent reply	other threads:[~2003-09-17  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-15 23:23 [PATCH] hamradio/scc - Stephen Hemminger
2003-09-16 20:53 ` Jeroen Vreeken
2003-09-17  6:35 ` Martijn Hijdra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1063780541.2971.4.camel@imst153.imst.de \
    --to=martijn@esrac.ele.tue.nl \
    --cc=jgarzik@pobox.com \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).