From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: David S Miller <davem@redhat.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@oss.sgi.com
Subject: [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h
Date: Wed, 24 Sep 2003 15:33:00 -0700 [thread overview]
Message-ID: <1064442780.15437.25.camel@localhost.localdomain> (raw)
In-Reply-To: <1064423867.15283.11.camel@localhost.localdomain>
On Wed, 2003-09-24 at 10:17, Joe Perches wrote:
> On Wed, 2003-09-24 at 10:13, Linus Torvalds wrote:
> > Looks sane, but wouldn't it be cleaner to put this ugly special case logic
> > with casts etc in an inline function and make the code a bit more readable
> > at the same time?
>
> I've got those.
>
> I've done the ((void*)1) conversions to PKT_SHARED_SKBs
> and found this missing. I'll submit those separately.
diff -urN linux-2.6.0-test5/include/linux/netdevice.h shared_skb/include/linux/netdevice.h
-- linux-2.6.0-test5/include/linux/netdevice.h 2003-09-22 08:04:03.000000000 -0700
+++ shared_skb/include/linux/netdevice.h 2003-09-22 13:10:07.000000000 -0700
@@ -477,6 +477,7 @@
*/
#define SET_NETDEV_DEV(net, pdev) ((net)->class_dev.dev = (pdev))
+#define PKT_CAN_SHARE_SKB ((void*)1)
struct packet_type
{
next prev parent reply other threads:[~2003-09-24 22:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-24 15:11 [PATCH] 2.6.0-bk6 net/core/dev.c Joe Perches
2003-09-24 17:13 ` Linus Torvalds
2003-09-24 17:17 ` Joe Perches
2003-09-24 22:33 ` Joe Perches [this message]
2003-09-24 22:36 ` [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h Linus Torvalds
2003-09-25 10:49 ` David S. Miller
2003-09-25 10:01 ` [PATCH] 2.6.0-bk6 net/core/dev.c David S. Miller
2003-09-24 22:33 ` [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [2/3] drivers/net/* Joe Perches
2003-09-24 22:33 ` [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [3/3] net/* Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064442780.15437.25.camel@localhost.localdomain \
--to=joe@perches.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).