From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: comment on [NET]: Delete support for old-style protocols, no longer necessary. Date: Tue, 07 Oct 2003 16:33:40 -0700 Sender: netdev-bounce@oss.sgi.com Message-ID: <1065569620.2340.19.camel@localhost.localdomain> References: <1065551829.2340.9.camel@localhost.localdomain> <20031007115244.14a887ed.davem@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: davem@nuts.ninka.net, linux-net@vger.kernel.org, netdev@oss.sgi.com Return-path: To: David S Miller In-Reply-To: <20031007115244.14a887ed.davem@redhat.com> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Tue, 2003-10-07 at 11:52, David S. Miller wrote: > On Tue, 07 Oct 2003 11:37:09 -0700 > Joe Perches wrote: > > > - void *af_packet_priv; > > + struct sock *sk; /* appropriate comment: socket copy? */ > > AF_PACKET is the only user of this private field, and > I want people to be aware of this and not try to use it > for other stuff. > > Nobody else can use it for something different, the code > in net/core/dev.c does specific things when it's non-NULL > knowing that this non-NULL value means that it's an > AF_PACKET packet_type being passed to it. > > So we won't make your suggested change. Even so, why not call it a struct sock*? It is after all and is used as one.