From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 1/4] ipv6: make inet6_fill_ifaddr() lockless
Date: Fri, 8 Mar 2024 08:26:56 -0700 [thread overview]
Message-ID: <106b95fc-139e-45dd-87ba-f8e536b37ff3@kernel.org> (raw)
In-Reply-To: <CANn89iJDfhJRPta063ujaASOvgvZ_imeBytm0OWsJ_7oKC4txg@mail.gmail.com>
On 3/6/24 11:24 PM, Eric Dumazet wrote:
> I did a full audit and I think I did not miss any READ_ONCE()/WRITE_ONCE()
>
> Of course, this is extra precaution anyway, the race has no impact
> other than KCSAN and/or would require a dumb compiler in the first
> place.
Then I guess I do not need to waste my time on a detailed review:
Acked-by: David Ahern <dsahern@kernel.org>
>
> If I had to explain this in the changelog, I guess I would not do all
> these changes, this would be too time consuming.
The request was something simple as the following in the changelog:
"New objects not in any list or table do not need the annotations, nor
do updates done while holding a lock."
Reminder for current reviewer and in the future of the intent behind the
change.
next prev parent reply other threads:[~2024-03-08 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 15:51 [PATCH net-next 0/4] ipv6: lockless inet6_dump_addr() Eric Dumazet
2024-03-06 15:51 ` [PATCH net-next 1/4] ipv6: make inet6_fill_ifaddr() lockless Eric Dumazet
2024-03-06 23:38 ` David Ahern
2024-03-07 6:24 ` Eric Dumazet
2024-03-08 15:26 ` David Ahern [this message]
2024-03-08 19:31 ` Jakub Kicinski
2024-03-06 15:51 ` [PATCH net-next 2/4] ipv6: make in6_dump_addrs() lockless Eric Dumazet
2024-03-06 15:51 ` [PATCH net-next 3/4] ipv6: use xa_array iterator to implement inet6_dump_addr() Eric Dumazet
2024-03-06 15:51 ` [PATCH net-next 4/4] ipv6: remove RTNL protection from inet6_dump_addr() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=106b95fc-139e-45dd-87ba-f8e536b37ff3@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).