From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH v4 bpf-next 0/2] bpf: add cg_skb_is_valid_access Date: Fri, 19 Oct 2018 01:46:40 +0000 Message-ID: <106cc871-ece8-7278-6b4b-1b1946f9a949@fb.com> References: <20181018160649.1611530-1-songliubraving@fb.com> <20181018233403.xnea2m7ntwxue44r@ast-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Cc: "netdev@vger.kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , Kernel Team To: Alexei Starovoitov , Song Liu Return-path: Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:34640 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbeJSJvZ (ORCPT ); Fri, 19 Oct 2018 05:51:25 -0400 In-Reply-To: <20181018233403.xnea2m7ntwxue44r@ast-mbp.dhcp.thefacebook.com> Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: On 10/18/18 4:34 PM, Alexei Starovoitov wrote: > On Thu, Oct 18, 2018 at 09:06:47AM -0700, Song Liu wrote: >> Changes v3 -> v4: >> 1. Fixed crash issue reported by Alexei. >> >> Changes v2 -> v3: >> 1. Added helper function bpf_compute_and_save_data_pointers() and >> bpf_restore_data_pointers(). >> >> Changes v1 -> v2: >> 1. Updated the list of read-only fields, and read-write fields. >> 2. Added dummy sk to bpf_prog_test_run_skb(). >> >> This set enables BPF program of type BPF_PROG_TYPE_CGROUP_SKB to access >> some __skb_buff data directly. > > Applied, Thanks Daniel brought up good point re: data_meta. Let's address it one way or the other and respin the series instead of adding follow up patches. So I tossed this series out of bpf-next.