Re: [PATCH net-next-2.6] bonding: set primary param via sysfs

[Jay Vosburgh <fubar@us.ibm.com>]

Jiri Pirko <jpirko@redhat.com> wrote:

>Primary module parameter passed to bonding is pernament. That means if you
>release the primary slave and enslave it again, it becomes the primary slave
>again. But if you set primary slave via sysfs, the primary slave is only set
>once and it's not remembered in bond->params structure. Therefore the setting is
>lost after releasing the primary slave. This simple one-liner fixes this.
>
>Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
>diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
>index 6044e12..ff449de 100644
>--- a/drivers/net/bonding/bond_sysfs.c
>+++ b/drivers/net/bonding/bond_sysfs.c
>@@ -1182,6 +1182,7 @@ static ssize_t bonding_store_primary(struct device *d,
> 				       ": %s: Setting %s as primary slave.\n",
> 				       bond->dev->name, slave->dev->name);
> 				bond->primary_slave = slave;
>+				strcpy(bond->params.primary, slave->dev->name);
> 				bond_select_active_slave(bond);
> 				goto out;
> 			}

	Looks good, fixes another bug I'd not heard of previously.

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>