From: Vivek Kumar Bhagat <vivek.bhagat@samsung.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
HEMANSHU SRIVASTAVA <hemanshu.s@samsung.com>,
Vikas Bansal <vikas.bansal@samsung.com>
Subject: Re^2: [PATCH] usbnet: add reset_resume quirk to prevent resume failure
Date: Mon, 04 Jul 2016 04:14:11 +0000 (GMT) [thread overview]
Message-ID: <1072936814.152611467605651369.JavaMail.weblogic@epmlwas01d> (raw)
Hello David,
Class driver .reset_resume() function will be called only when USB host driver has
set below flag, otherwise it will follow normal resume (without reset).
if (udev->quirks & USB_QUIRK_RESET_RESUME) <-- usb_resume_device()
udev->reset_resume = 1;
I shall remove cdc_eem changes, then it would be applicable for asix 2.0 device only.
I shall make one patch for asix 2.0 (asix_devices.c) and asix 3.0 (ax88179_178a.c).
We have verified on almost all type of available asix dongle.
I hope it would be okay.
Regards,
Vivek
------- Original Message -------
Sender : David Miller<davem@davemloft.net>
Date : Jul 02, 2016 01:28 (GMT+05:30)
Title : Re: [PATCH] usbnet: add reset_resume quirk to prevent resume failure
From: Vivek Kumar Bhagat
Date: Thu, 30 Jun 2016 10:41:59 +0000 (GMT)
>
> Ideally, usbnet_resume is sufficient for device resume operation.
> since usbcore function usb_resume_device() sets udev->reset_resume
> flag as a quirk solution, reset_resume() quirk we can keep in
> class driver also. We checked on dongle DA-Queen UFE20C,
> without reset function resume operation fails. Reason could be
> some power glitch during suspend time due to which device lose
> its internal state and it needs a device phy reset again during
> resume to recover.
>
> Signed-off-by: Vivek Kumar Bhagat
> Signed-off-by: Vikas Bansal
> Signed-off-by: Sangmin Bae
You've seen this necessary for one device, yet you are doing this
new reset for all usbnet devices.
That doesn't sound correct or safe at all.
I'm not applying this, sorry.
reply other threads:[~2016-07-04 4:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1072936814.152611467605651369.JavaMail.weblogic@epmlwas01d \
--to=vivek.bhagat@samsung.com \
--cc=davem@davemloft.net \
--cc=hemanshu.s@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=vikas.bansal@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).