From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next v2] ip-xfrm: Add support for OUTPUT_MARK Date: Wed, 13 Jun 2018 21:39:02 -0600 Message-ID: <107348e5-3035-8d07-59c0-95a84c4f8222@gmail.com> References: <1528829293-23222-1-git-send-email-subashab@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Stephen Hemminger , Steffen Klassert To: Lorenzo Colitti , Subash Abhinov Kasiviswanathan Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:33775 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935864AbeFNDjG (ORCPT ); Wed, 13 Jun 2018 23:39:06 -0400 Received: by mail-pg0-f66.google.com with SMTP id e11-v6so2253747pgq.0 for ; Wed, 13 Jun 2018 20:39:06 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 6/12/18 9:14 PM, Lorenzo Colitti wrote: > On Wed, Jun 13, 2018 at 3:48 AM Subash Abhinov Kasiviswanathan > wrote: >> >> src 192.168.1.1 dst 192.168.1.2 >> proto esp spi 0x00004321 reqid 0 mode tunnel >> replay-window 0 flag af-unspec >> mark 0x10000/0x3ffff >> output-mark 0x20000 > > Nit: I don't know what guarantees we provide (if any) that the output > format of "ip xfrm state" does not change except to add new lines at > the end. Personally, I feel that an app or script that depends on > "auth-trunc" (or anything else, really) being on the line immediately > after "mark" is brittle and should be fixed. This is particularly true > since in general between the mark and the encryption there might be an > auth-trunc line, or an auth line, or neither. As such, adding this > line here seems OK to me. any reason to put output-mark on its own line? Why not mark 0x10000/0x3ffff output-mark 0x20000 is the documentation clear on the difference between mark and output-mark? > >> @@ -61,6 +61,7 @@ static void usage(void) >> fprintf(stderr, " [ flag FLAG-LIST ] [ sel SELECTOR ] [ LIMIT-LIST ] [ encap ENCAP ]\n"); >> fprintf(stderr, " [ coa ADDR[/PLEN] ] [ ctx CTX ] [ extra-flag EXTRA-FLAG-LIST ]\n"); >> fprintf(stderr, " [ offload [dev DEV] dir DIR ]\n"); >> + fprintf(stderr, " [ output-mark OUTPUT-MARK]\n"); > > Nit: I think you want a space between OUTPUT-MARK and ]. yes. > > Other than that, > > Acked-by: Lorenzo Colitti >