From: Arnd Bergmann <arnd@arndb.de>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: netdev@vger.kernel.org, y2038@lists.linaro.org,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 3/4] net: ipv4: tcp_probe: Replace timespec with timespec64
Date: Thu, 25 Feb 2016 16:01:13 +0100 [thread overview]
Message-ID: <10756653.OfUfst5I70@wuerfel> (raw)
In-Reply-To: <1456384031-29244-4-git-send-email-deepa.kernel@gmail.com>
On Wednesday 24 February 2016 23:07:10 Deepa Dinamani wrote:
> TCP probe log timestamps use struct timespec which is
> not y2038 safe. Even though timespec might be good enough here
> as it is used to represent delta time, the plan is to get rid
> of all uses of timespec in the kernel.
> Replace with struct timespec64 which is y2038 safe.
>
> Prints still use unsigned long format and type.
> This is because long is 64 bit on 64 bit systems and 32 bit on
> 32 bit systems. Hence, time64_t(64 bit signed number) does not
> have a specifier that matches on both architectures.
Actually time64_t is always 'long long', but tv_sec is time_t
(long) instead of time64_t on 64-bit architectures.
Using a %ll format string and a cast to s64 would work as well,
but as you say above, it's not important here.
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-02-25 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 7:07 [PATCH 0/4] Convert network timestamps to be y2038 safe Deepa Dinamani
2016-02-25 7:07 ` [PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps Deepa Dinamani
2016-02-25 8:49 ` YOSHIFUJI Hideaki
2016-02-25 9:45 ` Deepa Dinamani
2016-02-26 6:49 ` YOSHIFUJI Hideaki/吉藤英明
2016-02-25 14:56 ` [Y2038] " Arnd Bergmann
2016-02-25 7:07 ` [PATCH 2/4] net: ipv4: Use y2038 safe functions and data structures Deepa Dinamani
2016-02-25 14:57 ` Arnd Bergmann
2016-02-25 7:07 ` [PATCH 3/4] net: ipv4: tcp_probe: Replace timespec with timespec64 Deepa Dinamani
2016-02-25 15:01 ` Arnd Bergmann [this message]
2016-02-27 2:56 ` Deepa Dinamani
2016-02-25 7:07 ` [PATCH 4/4] net: sctp: Convert log timestamps to be y2038 safe Deepa Dinamani
2016-02-25 14:09 ` Neil Horman
2016-02-25 14:56 ` [Y2038] " Arnd Bergmann
2016-02-26 20:19 ` [PATCH 0/4] Convert network " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10756653.OfUfst5I70@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=y2038@lists.linaro.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox