From: Marcel Holtmann <marcel@holtmann.org>
To: Andi Kleen <ak@suse.de>
Cc: bluez-devel@lists.sourceforge.net, netdev@oss.sgi.com,
viro@zenII.linux.org.uk
Subject: Re: some bluetooth fixes
Date: Sat, 07 Feb 2004 00:30:08 +0100 [thread overview]
Message-ID: <1076110207.14418.53.camel@pegasus> (raw)
In-Reply-To: <20040206050042.20a2b3b0.ak@suse.de>
Hi Andi,
> diff -u linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c-o linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c
> --- linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c-o 2003-09-28 10:53:25.000000000 +0200
> +++ linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c 2004-02-06 04:58:28.000000000 +0100
> @@ -549,8 +549,10 @@
>
> BT_DBG("dev %p dst %s channel %d opened %d", dev, batostr(&dev->dst), dev->channel, dev->opened);
>
> - if (dev->opened++ != 0)
> + if (dev->opened++ != 0) {
> + rfcomm_dev_put(dev);
> return 0;
> + }
>
> dlc = dev->dlc;
this part is wrong, because it is not an error case. It is success and
the refcount must stay increased.
Regards
Marcel
next prev parent reply other threads:[~2004-02-06 23:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-06 4:00 some bluetooth fixes Andi Kleen
2004-02-06 14:58 ` Marcel Holtmann
2004-02-07 2:24 ` Andi Kleen
2004-02-07 11:13 ` Marcel Holtmann
2004-02-07 11:57 ` Andi Kleen
2004-02-07 16:57 ` Marcel Holtmann
2004-02-07 17:24 ` Andi Kleen
2004-02-11 18:55 ` Marcel Holtmann
2004-02-11 19:33 ` Andi Kleen
2004-02-11 20:47 ` Marcel Holtmann
2004-02-11 19:55 ` Andi Kleen
2004-02-06 23:30 ` Marcel Holtmann [this message]
2004-02-06 23:34 ` David S. Miller
2004-02-06 23:46 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1076110207.14418.53.camel@pegasus \
--to=marcel@holtmann.org \
--cc=ak@suse.de \
--cc=bluez-devel@lists.sourceforge.net \
--cc=netdev@oss.sgi.com \
--cc=viro@zenII.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).