From: Mattias Forsblad <mattias.forsblad@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [RFC PATCH net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports
Date: Fri, 1 Apr 2022 07:21:52 +0200 [thread overview]
Message-ID: <10775971-c700-4b7b-77f5-6d6cd221de67@gmail.com> (raw)
In-Reply-To: <20220331134257.zi32tftbz3yo2lg3@skbuf>
On 2022-03-31 15:42, Vladimir Oltean wrote:
> On Thu, Mar 31, 2022 at 10:06:20AM +0200, Mattias Forsblad wrote:
>> Hi Vladimir,
>> thanks for your comments. The patch series takes in account that a foreign
>> interface is bridged and doesn't offload the rule in this case (dsa_slave_check_offload).
>
> I certainly appreciate the intention, but it could be that a foreign
> interface will join the bridge after the matchall action drop is
> installed on the bridge. So actively monitoring bridge joins/leaves
> would be required to offload/unoffload the rule.
>
Ah, you're right. I'll fix that. Thanks.
prev parent reply other threads:[~2022-04-01 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 11:31 [RFC PATCH net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports Mattias Forsblad
2022-03-30 11:31 ` [RFC PATCH net-next 1/2] net: tc: dsa: Add the matchall filter with drop action " Mattias Forsblad
2022-03-30 11:31 ` [RFC PATCH net-next 2/2] net: dsa: Implement tc offloading for drop target Mattias Forsblad
2022-03-30 12:09 ` [RFC PATCH net-next 0/2] net: tc: dsa: Implement offload of matchall for bridged DSA ports Vladimir Oltean
2022-03-31 8:06 ` Mattias Forsblad
2022-03-31 13:42 ` Vladimir Oltean
2022-04-01 5:21 ` Mattias Forsblad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10775971-c700-4b7b-77f5-6d6cd221de67@gmail.com \
--to=mattias.forsblad@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox