From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45672C433FE for ; Tue, 8 Nov 2022 06:18:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233215AbiKHGSl (ORCPT ); Tue, 8 Nov 2022 01:18:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233082AbiKHGSi (ORCPT ); Tue, 8 Nov 2022 01:18:38 -0500 Received: from nbd.name (nbd.name [46.4.11.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF00E175AA; Mon, 7 Nov 2022 22:18:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cOvKtImoCc+4ueMzSyfE0QUAmGLsxVWwkMiYhxnzlLg=; b=t/85Ae3ntaIkFxmdc2a54YM/rG QymwJJuaXe00KiA6j5IHZJGStQ70Pa0cohn1M0lNbUyOWWTErEDq5o6SsQFrBhV7l15732N3icAXq vRdti1b0/Cos5F2JvLwU4i7PpFYLQJ0uagnbwwYYUD4j8kZl7gE1/EjWlflR0CXlV1dA=; Received: from p200300daa72ee1006d973cebf3767a25.dip0.t-ipconnect.de ([2003:da:a72e:e100:6d97:3ceb:f376:7a25] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1osHwH-000S7w-4W; Tue, 08 Nov 2022 07:18:25 +0100 Message-ID: <1078ae93-490b-60b5-d1ae-95ca491cfb15@nbd.name> Date: Tue, 8 Nov 2022 07:18:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 01/14] net: ethernet: mtk_eth_soc: account for vlan in rx header length Content-Language: en-US To: Vladimir Oltean Cc: netdev@vger.kernel.org, John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221107185452.90711-1-nbd@nbd.name> <20221107205553.cnydzeh3tmilqblx@skbuf> From: Felix Fietkau In-Reply-To: <20221107205553.cnydzeh3tmilqblx@skbuf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 07.11.22 21:55, Vladimir Oltean wrote: > On Mon, Nov 07, 2022 at 07:54:39PM +0100, Felix Fietkau wrote: >> This may be needed for correct MTU settings on devices using DSA >> >> Signed-off-by: Felix Fietkau >> --- >> drivers/net/ethernet/mediatek/mtk_eth_soc.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h >> index 589f27ddc401..dcf2a0d5da33 100644 >> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h >> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h >> @@ -29,7 +29,7 @@ >> #define MTK_TX_DMA_BUF_LEN_V2 0xffff >> #define MTK_DMA_SIZE 512 >> #define MTK_MAC_COUNT 2 >> -#define MTK_RX_ETH_HLEN (ETH_HLEN + ETH_FCS_LEN) >> +#define MTK_RX_ETH_HLEN (VLAN_ETH_HLEN + ETH_HLEN + ETH_FCS_LEN) > > Commit title says account for VLAN (VLAN_HLEN, 4 bytes), code says add > VLAN_ETH_HLEN (18) more bytes. > > Also, why is DSA mentioned in the commit message? Is accounting for VLAN > hlen not needed if DSA is not used? Why? Will fix the code and improve the comments in v2. - Felix