From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH bpf-next] bpf: better availability probing for seg6 helpers Date: Wed, 11 Jul 2018 22:35:21 +0200 Message-ID: <107fd268-2944-89aa-d565-5a77c41fd44d@iogearbox.net> References: <20180710165402.26605-1-m.xhonneux@gmail.com> <5da76612-54b4-d616-6def-a103cafee074@iogearbox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: alexei.starovoitov@gmail.com To: Mathieu Xhonneux , netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:41715 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbeGKUlZ (ORCPT ); Wed, 11 Jul 2018 16:41:25 -0400 In-Reply-To: <5da76612-54b4-d616-6def-a103cafee074@iogearbox.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/10/2018 09:20 PM, Daniel Borkmann wrote: > On 07/10/2018 06:54 PM, Mathieu Xhonneux wrote: >> bpf_lwt_seg6_* helpers require CONFIG_IPV6_SEG6_BPF, and currently >> return -EOPNOTSUPP to indicate unavailability. This patch forces the >> BPF verifier to reject programs using these helpers when >> !CONFIG_IPV6_SEG6_BPF, allowing users to more easily probe if they are >> available or not. >> >> Signed-off-by: Mathieu Xhonneux > > Note, just fyi, this would need to go to bpf tree (and not bpf-next) as > otherwise there's a change in behavior. Applied, thanks Mathieu!