From: Max Krasnyansky <maxk@qualcomm.com>
To: hadi@cyberus.ca
Cc: netdev@oss.sgi.com, syrius.ml@no-log.org,
Jeff Garzik <jgarzik@pobox.com>,
"David S. Miller" <davem@redhat.com>
Subject: Re: tun device - bug or feature? WAS(Re: IMQ / new Dummy device post.
Date: Mon, 26 Apr 2004 12:31:38 -0700 [thread overview]
Message-ID: <1083007898.7788.276.camel@localhost> (raw)
In-Reply-To: <1082816083.1054.32.camel@jzny.localdomain>
On Sat, 2004-04-24 at 07:14, jamal wrote:
> Maxim,
>
> When TUN_TUN_DEV is used, before the packet is injected into
> the netif_rx() only skb->mac.raw = skb->data is set; the other headers
> are not adjusted. Typically netdevs would do a
> skb_pull(skb,dev->hard_header_len) to make the adjustment.
> I have a feeling this is design intent thats why i didnt send you a
> patch.
Well TUN does not have any hw headers so there is nothing to pull :).
Basically it does what ever PPP driver does. Which is
skb_pull(skb, 2); /* chop off protocol */
skb->dev = ppp->dev;
skb->protocol = htons(npindex_to_ethertype[npi]);
skb->mac.raw = skb->data;
netif_rx(skb);
Max
next prev parent reply other threads:[~2004-04-26 19:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-19 14:22 IMQ / new Dummy device post syrius.ml
2004-04-20 2:15 ` jamal
2004-04-21 1:43 ` syrius.ml
2004-04-21 12:49 ` syrius.ml
2004-04-21 20:19 ` syrius.ml
2004-04-22 13:16 ` jamal
2004-04-22 17:43 ` syrius.ml
2004-04-23 11:29 ` jamal
2004-04-24 14:14 ` tun device - bug or feature? WAS(Re: " jamal
2004-04-26 4:38 ` David S. Miller
2004-04-26 19:31 ` Max Krasnyansky [this message]
2004-04-27 2:22 ` jamal
2004-05-08 11:55 ` jamal
2004-05-10 17:18 ` Max Krasnyansky
2004-06-05 13:24 ` PATCH: " jamal
2004-06-05 21:42 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083007898.7788.276.camel@localhost \
--to=maxk@qualcomm.com \
--cc=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=syrius.ml@no-log.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).