netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: David S Miller <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH] common code for generating tcp_info
Date: Mon, 07 Jun 2004 07:48:18 -0700	[thread overview]
Message-ID: <1086619698.4113.22.camel@localhost.localdomain> (raw)
In-Reply-To: <20040604153749.5d8a13b9@dell_ss3.pdx.osdl.net>

On Fri, 2004-06-04 at 15:37, Stephen Hemminger wrote:

> diff -Nru a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c
> --- a/net/ipv4/tcp_diag.c	2004-06-04 15:35:55 -07:00
> +++ b/net/ipv4/tcp_diag.c	2004-06-04 15:35:55 -07:00
> +void tcp_get_info(struct sock *sk, struct tcp_info *info)

What is the appropriate text to update tcp.h?

	/* The syn_wait_lock is necessary only to avoid tcp_get_info having
	 * to grab the main lock sock while browsing the listening hash
	 * (otherwise it's deadlock prone).
	 * This lock is acquired in read mode only from tcp_get_info() and
	 * it's acquired in write mode _only_ from code that is actively
	 * changing the syn_wait_queue. All readers that are holding
	 * the master sock lock don't need to grab this lock in read mode
	 * too as the syn_wait_queue writes are always protected from
	 * the main sock lock.
	 */

  parent reply	other threads:[~2004-06-07 14:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-04 22:37 [PATCH] common code for generating tcp_info Stephen Hemminger
2004-06-05  3:57 ` David S. Miller
2004-06-07 17:07   ` [PATCH] add receive DRS info Stephen Hemminger
2004-06-07 22:27     ` David S. Miller
2004-06-07 14:48 ` Joe Perches [this message]
2004-06-07 16:16   ` [PATCH] common code for generating tcp_info Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1086619698.4113.22.camel@localhost.localdomain \
    --to=joe@perches.com \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).