From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Gruenbacher Subject: Re: [NAT-T] NON-IKE encapsulation Date: Sat, 26 Jun 2004 00:13:42 +0200 Sender: netdev-bounce@oss.sgi.com Message-ID: <1088201622.25933.9.camel@winden.suse.de> References: <20040624123603.GA1241@gondor.apana.org.au> <20040625101231.6f6b2f12.davem@redhat.com> <20040625215747.GA14930@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netdev@oss.sgi.com Return-path: To: Herbert Xu In-Reply-To: <20040625215747.GA14930@gondor.apana.org.au> Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Hello, On Fri, 2004-06-25 at 23:57, Herbert Xu wrote: > On Fri, Jun 25, 2004 at 10:12:31AM -0700, David S. Miller wrote: > > > > I now think it's trying to account for the udpdata32[] header area. > > But that's not 2 bytes, it's (2 * sizeof(u32)) or 8 bytes. > > That's what I thought too, but that is already accounted by > x->props.header_len in init_state. > > In any case, just increasing alen like that is wrong. It needs to > do at least three other things: > > 1. Allocate memory for it in skb_cow_data. > 2. Fill in those bytes with data so we don't leak information. > 3. Teach get_max_size about it. > > Andreas, can you please clarify for us as to what those two bytes > are for? I think I'm not the right person to address this question to .Did you mean to ask Dave? I'm also missing the context here I'm afraid; is there an archive of the whole thread somewhere? Cheers, -- Andreas Gruenbacher SUSE Labs, SUSE LINUX AG