From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0701C43381 for ; Sat, 16 Feb 2019 09:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 67E14222D0 for ; Sat, 16 Feb 2019 09:20:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z2fsu7xw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731754AbfBPJUZ (ORCPT ); Sat, 16 Feb 2019 04:20:25 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36978 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbfBPJUZ (ORCPT ); Sat, 16 Feb 2019 04:20:25 -0500 Received: by mail-wr1-f65.google.com with SMTP id c8so12755254wrs.4 for ; Sat, 16 Feb 2019 01:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=+/AwnyBC8Clu302aTHY5DJgoE0d7zMQNblYi6BNjDOk=; b=Z2fsu7xwVgeXp+KF1757kJG6VBWOjSjzIWqb7u5+WBQIh0M2PwJjGOogDz12VHOqOi Tacd8yMhJJXEelkZXmS5Vbs/6oGaPudo7Hl11EoNx7lHszm0gw3nLeDisNG/O64WwWcx 8/V3yLXSMZTjDkOuBjL8ieu0U6snu8bBbTAdW2LXcqhtdL0T237kARmYWi9jxHhBZUvE PbfKHStnReihsICzKq0acx5ALi5878XkMWONOBWGCpHBuS8QA2RLRdNTi0xVe1Iw9oJF BTcc6lq9tCDME7CXxAULgiZS/b2VPAGVq5NKRpZ/LKkz0vHeGMibq0hre2CKmCQLIc5z f/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=+/AwnyBC8Clu302aTHY5DJgoE0d7zMQNblYi6BNjDOk=; b=QndeJ7dbNmaJhKzTYJa/BlCfkIjg32dzNXjR9OTehPfXOjGu0RRTzCrV5DHJVrmAYc GdiO8Gj50498DuEs7qfA7jTU+qc7kdbpyv6cNHa+2DV5QnN1QRiYGrn9KvfndxVgdd5q 4SZexULUoHkh4Ex/m3YZmkOPFQsLYx+okrS7Yv4EHbXKZPRLXOGr/8OXnTcMKXHlnjUH J3eyhBgtcjEX+cMtf9cRF+x3jFAgnnACd4GT9/yaWxI79XR/JSYGYXlMB64C5fKKUo1/ ZiESwOgdXGUAaWaWG9vdXHRzTv/6Cmg5Mx3ONiTjtFyksd33SlXiPdXgfo8PIIZhlpuG qWJg== X-Gm-Message-State: AHQUAuZW+AKgE6JTaEvK+0TpTMHan+uEdRUYPWnGJZhejAHNddqanleS 5xMInUdrrcEKroscqkeIRU4bJI+J X-Google-Smtp-Source: AHgI3IYi7ZagmZ49oFUKhS/4pfgcxKYh44KZDYsadZekjyuD2Kblkk9vREZvsa5IZqTVaiOpbiNpow== X-Received: by 2002:a5d:548f:: with SMTP id h15mr9599564wrv.238.1550308823482; Sat, 16 Feb 2019 01:20:23 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:fc50:d076:bfa9:dffa? (p200300EA8BF1E200FC50D076BFA9DFFA.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:fc50:d076:bfa9:dffa]) by smtp.googlemail.com with ESMTPSA id h5sm5711983wrt.38.2019.02.16.01.20.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Feb 2019 01:20:22 -0800 (PST) To: Realtek linux nic maintainers , David Miller Cc: "netdev@vger.kernel.org" From: Heiner Kallweit Subject: [PATCH net-next] r8169: remove unneeded mmiowb barriers Message-ID: <10883db9-493c-7434-2379-de79712cee85@gmail.com> Date: Sat, 16 Feb 2019 10:20:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org writex() has implicit barriers, that's what makes it different from writex_relaxed(). Therefore these calls to mmiowb() can be removed. This patch was recently reverted due to a dependency with another problematic patch. But because it didn't contribute to the problem it was rebased and can be resubmitted. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 548fe260b..3cca2ffb2 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -1288,13 +1288,11 @@ static u8 rtl8168d_efuse_read(struct rtl8169_private *tp, int reg_addr) static void rtl_ack_events(struct rtl8169_private *tp, u16 bits) { RTL_W16(tp, IntrStatus, bits); - mmiowb(); } static void rtl_irq_disable(struct rtl8169_private *tp) { RTL_W16(tp, IntrMask, 0); - mmiowb(); } #define RTL_EVENT_NAPI_RX (RxOK | RxErr) @@ -6251,8 +6249,6 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb, RTL_W8(tp, TxPoll, NPQ); - mmiowb(); - if (!rtl_tx_slots_avail(tp, MAX_SKB_FRAGS)) { /* Avoid wrongly optimistic queue wake-up: rtl_tx thread must * not miss a ring update when it notices a stopped queue. @@ -6597,9 +6593,7 @@ static int rtl8169_poll(struct napi_struct *napi, int budget) if (work_done < budget) { napi_complete_done(napi, work_done); - rtl_irq_enable(tp); - mmiowb(); } return work_done; -- 2.20.1