From: Christophe Saout <christophe@saout.de>
To: Nivedita Singhvi <niv@us.ibm.com>
Cc: James Morris <jmorris@intercode.com.au>,
akpm@osdl.org, netdev <netdev@oss.sgi.com>,
mjbligh@us.ibm.com
Subject: Re: [Fwd: [Bug 3003] New: might_sleep warning when setting up IPSec with IPCOMP]
Date: Fri, 02 Jul 2004 23:35:59 +0200 [thread overview]
Message-ID: <1088804159.763.5.camel@leto.cs.pocnet.net> (raw)
In-Reply-To: <40E5D326.5000509@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
Am Fr, den 02.07.2004 um 14:27 Uhr -0700 schrieb Nivedita Singhvi:
> We are grabbing dst->xfrm lock in ipcomp_output(),
> and have it held when we call ipcomp_compress().
>
> Is that the issue? I don't have the crypto module
> code, but in_atomic() will be true.
Yes. But the code might also be called from softirq context, when a
packed from the NIC gets handled or when a slot in the queue becomes
free. (I've also got warnings from those two cases in my logs)
The compress/decompress calls should be able to be run from softirq
(atomic) context just like encrypt/decrypt.
I'm just wondering, why does deflate_compress call deflate_comp_init
when it is called the first time, but deflate_init is a noop? Shouldn't
the deflate_comp_init call just be moved to deflate_init?
[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-07-02 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 17:56 [Fwd: [Bug 3003] New: might_sleep warning when setting up IPSec with IPCOMP] Nivedita Singhvi
2004-07-02 17:58 ` Christophe Saout
2004-07-02 21:27 ` Nivedita Singhvi
2004-07-02 21:35 ` Christophe Saout [this message]
2004-07-02 21:39 ` Andrew Morton
2004-07-09 4:20 ` James Morris
2004-07-09 23:58 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088804159.763.5.camel@leto.cs.pocnet.net \
--to=christophe@saout.de \
--cc=akpm@osdl.org \
--cc=jmorris@intercode.com.au \
--cc=mjbligh@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=niv@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).