* [PATCH 2.6] convert ipvs to module_param
@ 2004-07-23 20:11 Stephen Hemminger
2004-07-23 21:23 ` David S. Miller
2004-07-24 14:45 ` Rusty Russell
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2004-07-23 20:11 UTC (permalink / raw)
To: David S. Miller, wensong; +Cc: netdev, Rusty Russell
Convert IPVS to not use MODULE_PARM.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
diff -Nru a/net/ipv4/ipvs/ip_vs_ftp.c b/net/ipv4/ipvs/ip_vs_ftp.c
--- a/net/ipv4/ipvs/ip_vs_ftp.c 2004-07-23 13:04:54 -07:00
+++ b/net/ipv4/ipvs/ip_vs_ftp.c 2004-07-23 13:04:54 -07:00
@@ -25,6 +25,7 @@
*/
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/kernel.h>
#include <linux/skbuff.h>
#include <linux/in.h>
@@ -44,16 +45,17 @@
* First port is set to the default port.
*/
static int ports[IP_VS_APP_MAX_PORTS] = {21, 0};
+static int ports_c;
+module_param_array(ports, int, ports_c, 0);
/*
* Debug level
*/
#ifdef CONFIG_IP_VS_DEBUG
static int debug=0;
-MODULE_PARM(debug, "i");
+module_param(debug, int, 0);
#endif
-MODULE_PARM(ports, "1-" __MODULE_STRING(IP_VS_APP_MAX_PORTS) "i");
/* Dummy variable */
static int ip_vs_ftp_pasv;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2.6] convert ipvs to module_param
2004-07-23 20:11 [PATCH 2.6] convert ipvs to module_param Stephen Hemminger
@ 2004-07-23 21:23 ` David S. Miller
2004-07-24 14:45 ` Rusty Russell
1 sibling, 0 replies; 3+ messages in thread
From: David S. Miller @ 2004-07-23 21:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: wensong, netdev, rusty
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6] convert ipvs to module_param
2004-07-23 20:11 [PATCH 2.6] convert ipvs to module_param Stephen Hemminger
2004-07-23 21:23 ` David S. Miller
@ 2004-07-24 14:45 ` Rusty Russell
1 sibling, 0 replies; 3+ messages in thread
From: Rusty Russell @ 2004-07-24 14:45 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David S. Miller, wensong, netdev
On Sat, 2004-07-24 at 06:11, Stephen Hemminger wrote:
> #ifdef CONFIG_IP_VS_DEBUG
> static int debug=0;
> -MODULE_PARM(debug, "i");
> +module_param(debug, int, 0);
> #endif
Sure you want 0 here? Wouldn't it be nice to change it on the fly?
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-07-24 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-23 20:11 [PATCH 2.6] convert ipvs to module_param Stephen Hemminger
2004-07-23 21:23 ` David S. Miller
2004-07-24 14:45 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).