From: Scott Feldman <sfeldma@pobox.com>
To: Ganesh Venkatesan <ganesh.venkatesan@intel.com>
Cc: jgarzik@pobox.com, netdev@oss.sgi.com
Subject: Re: [patch 4/8 2.5] e1000 Check value returned by from pci_enable_device
Date: Fri, 17 Sep 2004 20:05:10 -0700 [thread overview]
Message-ID: <1095476710.3496.13.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44.0409170233040.15233-100000@isotope.jf.intel.com>
On Fri, 2004-09-17 at 02:57, Ganesh Venkatesan wrote:
> diff -up linux-2.5/drivers/net/e1000/e1000_main.c linux-2.5/drivers/net/e1000.new/e1000_main.c
> --- linux-2.5/drivers/net/e1000/e1000_main.c 2004-09-09 11:17:11.000000000 -0700
> +++ linux-2.5/drivers/net/e1000.new/e1000_main.c 2004-09-09 11:17:12.000000000 -0700
> @@ -2881,9 +2881,9 @@ e1000_resume(struct pci_dev *pdev)
> {
> struct net_device *netdev = pci_get_drvdata(pdev);
> struct e1000_adapter *adapter = netdev->priv;
> - uint32_t manc;
> + uint32_t manc, ret;
>
> - pci_enable_device(pdev);
> + ret = pci_enable_device(pdev);
> pci_set_power_state(pdev, 0);
> pci_restore_state(pdev, adapter->pci_state);
Where is the check of the return value? I just see an assignment to an
automatic that gets tossed (probably by the compiler if it's paying
attention).
-scott
prev parent reply other threads:[~2004-09-18 3:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 9:57 [patch 4/8 2.5] e1000 Check value returned by from pci_enable_device Ganesh Venkatesan
2004-09-18 3:05 ` Scott Feldman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095476710.3496.13.camel@localhost.localdomain \
--to=sfeldma@pobox.com \
--cc=ganesh.venkatesan@intel.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox