From: jamal <hadi@cyberus.ca>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Clean up fib_hash datastructures
Date: 19 Sep 2004 20:39:43 -0400 [thread overview]
Message-ID: <1095640781.1047.168.camel@jzny.localdomain> (raw)
In-Reply-To: <20040918203319.24004d6e.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Sat, 2004-09-18 at 23:33, David S. Miller wrote:
> So, before we even think about trying new faster algorithms
> in net/ipv4/fib_hash.c we have to clean it up.
Will look at rest of patch and get back to you. Curious piece like you
note:
> Does anyone know what this test:
>
> if (!iter->zone->fz_next)
> continue;
>
> in fib_get_first() is doing? I kept it there
> but it looks fishy.
Yes, it is fishy;-> patch attached. Probably one of the more interesting
typos i have seen recently
cheers,
jamal
[-- Attachment #2: fibhash_p --]
[-- Type: text/plain, Size: 288 bytes --]
--- a/net/ipv4/fib_hash.c 2004/09/20 00:35:16 1.1
+++ b/net/ipv4/fib_hash.c 2004/09/20 00:36:16
@@ -915,7 +915,7 @@
iter->zone = iter->zone->fz_next) {
int maxslot;
- if (!iter->zone->fz_next)
+ if (!iter->zone->fz_nent)
continue;
iter->hash = iter->zone->fz_hash;
next prev parent reply other threads:[~2004-09-20 0:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-19 3:33 [PATCH] Clean up fib_hash datastructures David S. Miller
2004-09-20 0:39 ` jamal [this message]
2004-09-20 2:46 ` David S. Miller
2004-09-20 3:14 ` Herbert Xu
2004-09-20 3:17 ` David S. Miller
2004-09-20 13:33 ` jamal
2004-09-20 1:51 ` jamal
2004-09-20 2:53 ` David S. Miller
2004-09-20 13:24 ` jamal
2004-09-20 19:11 ` David S. Miller
2004-09-21 3:42 ` Herbert Xu
2004-09-21 6:18 ` David S. Miller
2004-09-21 9:04 ` Andi Kleen
2004-09-21 9:32 ` Herbert Xu
2004-09-21 11:03 ` jamal
2004-09-21 12:07 ` Andi Kleen
2004-09-21 12:22 ` jamal
2004-09-21 23:38 ` Steven Blake
2004-09-22 3:10 ` jamal
2004-09-22 11:56 ` Steven Blake
2004-09-22 12:12 ` jamal
2004-09-22 20:04 ` Steven Blake
2004-09-22 2:07 ` Herbert Xu
2004-09-22 2:32 ` David S. Miller
2004-09-22 3:57 ` [IPv4] Check PAGE_SIZE in fz_hash_alloc Herbert Xu
2004-09-23 20:05 ` David S. Miller
2004-09-22 3:30 ` [PATCH] Clean up fib_hash datastructures jamal
2004-09-22 3:36 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095640781.1047.168.camel@jzny.localdomain \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox