From: jamal <hadi@cyberus.ca>
To: Thomas Graf <tgraf@suug.ch>
Cc: Harald Welte <laforge@gnumonks.org>,
Robert Olsson <Robert.Olsson@data.slu.se>,
Stephen Hemminger <shemminger@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
herbert@gondor.apana.org.au, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] generic network statistics (was Re: [6/6]: jenkins hash for neigh / Statistics)
Date: 28 Sep 2004 22:22:07 -0400 [thread overview]
Message-ID: <1096424527.1044.94.camel@jzny.localdomain> (raw)
In-Reply-To: <20040928133334.GW31616@rei.reeler.org>
On Tue, 2004-09-28 at 09:33, Thomas Graf wrote:
> > Speaking of generic stats; i have a patch netlink ready which may need
> > some extensions. I did post it a while back on netdev but didnt get
> > feedback.
>
> The code looks good and I couldn't spot any errors but I'm not
> sure if the locking in gen_copy_[x]stats is a good thing.
> Shouldn't that be done earlier by the caller?
In the netsched code that became a portability issue; Dave fixed it
there, so i just replicated here. If you feel like doing something
clever you are welcome to submit a patch.
> This prevents
> corruption but it allows duplicated TLVs in an skb. I suggest
> to make the caller have a lock on his data and only allow one
> dumper at the same time until the dump is complete, or at least
> provide a lockless variant for callers doing the locking on
> their own.
>
Reminds me:
gnet_stats needs to have TLVs embedded in it.
bytes,drops, packets are generic enough; others are not.
So if we add a length field then we can add TLVs for things like
QSTATS = { qlen, backlog} etc.
This means we could then allow for adding a lot of different
stats. A big lesson from current tc_stats.
cheers,
jamal
next prev parent reply other threads:[~2004-09-29 2:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-24 5:51 [6/6]: jenkins hash for neigh David S. Miller
2004-09-24 8:52 ` Harald Welte
2004-09-24 21:27 ` David S. Miller
2004-09-25 6:44 ` Harald Welte
2004-09-25 7:56 ` David S. Miller
2004-09-25 8:14 ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-25 8:27 ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-25 8:30 ` David S. Miller
2004-09-25 9:09 ` Harald Welte
2004-09-25 13:33 ` Steven Whitehouse
2004-09-26 0:48 ` David S. Miller
2004-09-26 3:31 ` David S. Miller
2004-09-26 11:21 ` Thomas Graf
2004-09-27 9:29 ` Harald Welte
2004-09-27 18:57 ` David S. Miller
2004-09-26 10:11 ` YOSHIFUJI Hideaki / 吉藤英明
2004-09-27 11:43 ` Herbert Xu
2004-09-27 19:12 ` David S. Miller
2004-09-27 11:48 ` Herbert Xu
2004-09-27 18:15 ` David S. Miller
2004-09-27 21:41 ` Herbert Xu
2004-09-27 22:00 ` Herbert Xu
2004-10-02 7:50 ` Herbert Xu
2004-10-03 21:55 ` David S. Miller
2004-09-27 11:56 ` Herbert Xu
2004-09-27 19:14 ` David S. Miller
2004-09-27 22:26 ` [6/6]: jenkins hash for neigh / Statistics Harald Welte
2004-09-27 23:06 ` David S. Miller
2004-09-27 23:27 ` Stephen Hemminger
2004-09-28 8:44 ` Robert Olsson
2004-09-28 11:19 ` [PATCH 2.6] generic network statistics (was Re: [6/6]: jenkins hash for neigh / Statistics) Harald Welte
2004-09-28 12:48 ` jamal
2004-09-28 13:33 ` Thomas Graf
2004-09-29 2:22 ` jamal [this message]
2004-09-28 14:22 ` Robert Olsson
2004-09-29 2:16 ` jamal
2004-09-28 14:55 ` Harald Welte
2004-09-28 15:17 ` Robert Olsson
2004-09-28 16:24 ` Harald Welte
2004-09-28 21:43 ` David S. Miller
2004-09-29 8:04 ` Harald Welte
2004-09-28 16:27 ` [6/6]: jenkins hash for neigh / Statistics Stephen Hemminger
2004-09-28 17:06 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096424527.1044.94.camel@jzny.localdomain \
--to=hadi@cyberus.ca \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=laforge@gnumonks.org \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox