From: Arjan van de Ven <arjan@fenrus.demon.nl>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org,
jgarzik@pobox.com, davem@davemloft.net, john.ronciak@intel.com,
ganesh.venkatesan@intel.com, akpm@osdl.org, romieu@fr.zoreil.com,
ctindel@users.sourceforge.net, fubar@us.ibm.com,
greearb@candelatech.com
Subject: Re: [patch 2.6.9 0/11] Add MODULE_VERSION to several network drivers
Date: Thu, 21 Oct 2004 16:11:17 +0200 [thread overview]
Message-ID: <1098367875.2810.36.camel@laptop.fenrus.com> (raw)
In-Reply-To: <20041021085509.B29340@tuxdriver.com>
On Thu, 2004-10-21 at 14:55, John W. Linville wrote:
> > Not really. I have absolutely no problem with a MODULE_VERSION macro
> > *IF* the version it advertises means something. However if the version
> > it advertises has no meaning whatsoever (eg the version number never
> > gets updated) then imo it's better to NOT advertise anything so that
> > other tools (like dkms) don't make assumptions and decisions based on
> > nothing-meaning data.
>
> Again, I think it would have to be the maintainer's responsibility
> to make the version numbers meaningful.
absolutely; however you're not the maintainer of all of the ones you
patched... and I still argue that until the number is meaningful
exporting it as meaning something is more harm than good.
next prev parent reply other threads:[~2004-10-21 14:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:11 [patch 2.6.9 0/11] Add MODULE_VERSION to several network drivers John W. Linville
2004-10-20 18:14 ` [patch 2.6.9 1/11] tg3: Add MODULE_VERSION John W. Linville
2004-10-20 18:33 ` John W. Linville
2004-10-21 4:24 ` David S. Miller
2004-10-20 18:15 ` [patch 2.6.9 2/11] e100: " John W. Linville
2004-10-20 18:34 ` John W. Linville
2004-10-20 18:16 ` [patch 2.6.9 3/11] e1000: " John W. Linville
2004-10-20 18:35 ` John W. Linville
2004-10-20 18:17 ` [patch 2.6.9 4/11] b44: " John W. Linville
2004-10-20 18:36 ` John W. Linville
2004-10-21 4:25 ` David S. Miller
2004-10-20 18:20 ` [patch 2.6.9 5/11] tulip: " John W. Linville
2004-10-20 18:21 ` [patch 2.6.9 6/11] 3c59x: " John W. Linville
2004-10-20 18:23 ` [patch 2.6.9 7/11] 8139too: " John W. Linville
2004-10-20 18:27 ` [patch 2.6.9 8/11] ns83820: " John W. Linville
2004-10-20 18:28 ` [patch 2.6.9 9/11] r8169: " John W. Linville
2004-10-20 20:34 ` Richard B. Johnson
2004-10-20 19:59 ` John W. Linville
2004-10-21 12:33 ` Richard B. Johnson
2004-10-20 18:29 ` [patch 2.6.9 10/11] bonding: " John W. Linville
2004-10-20 18:32 ` [patch 2.6.9 11/11] vlan: " John W. Linville
2004-10-21 9:17 ` [patch 2.6.9 0/11] Add MODULE_VERSION to several network drivers Arjan van de Ven
2004-10-21 12:22 ` John W. Linville
2004-10-21 13:46 ` Arjan van de Ven
2004-10-21 12:55 ` John W. Linville
2004-10-21 14:11 ` Arjan van de Ven [this message]
2004-10-21 13:33 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098367875.2810.36.camel@laptop.fenrus.com \
--to=arjan@fenrus.demon.nl \
--cc=akpm@osdl.org \
--cc=ctindel@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=ganesh.venkatesan@intel.com \
--cc=greearb@candelatech.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@oss.sgi.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).