From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: net: generic netdev_ioaddr Date: Sat, 30 Oct 2004 12:52:26 +0300 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <1099129946.10961.9.camel@localhost> References: <1099044244.9566.0.camel@localhost> <20041029131607.GU24336@parcelfarce.linux.theplanet.co.uk> <20041029193827.GV24336@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Cc: Al Viro , davem@davemloft.net, netdev@oss.sgi.com, linux-kernel@vger.kernel.org Return-path: To: Krzysztof Halasa In-Reply-To: List-Id: netdev.vger.kernel.org Hi, Al Viro writes: > > What uses ->base_addr from the data returned by SIOCGIFMAP? On Fri, 2004-10-29 at 23:13 +0200, Krzysztof Halasa wrote: > > ifconfig I think: [snip] > With this driver it happens to be MMIO address. > > I understand presenting this value to users might have some value: > it can help determine the physical port/card for a given netdev. > But it should be something like a description text set by the driver > (ie. containing PCI bus/device, or even ISA address for ISA non-PnP > card, possibly with other information). It seems that the user can also setup dev->base_addr with "netdev=" kernel parameter before a driver starts probing (for example drivers/net/appletalk/cops.c). Should we get rid of "netdev=" too and push preconfiguring down to the drivers that actually use it? Pekka