From: Florian Fainelli <f.fainelli@gmail.com>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: turn carrier off on phy attach
Date: Tue, 12 Jan 2016 17:31:04 -0800 [thread overview]
Message-ID: <10DF45FB-A812-4D6F-8B45-817B86FD48CE@gmail.com> (raw)
In-Reply-To: <1452365045-5364-1-git-send-email-sjoerd.simons@collabora.co.uk>
On January 9, 2016 10:44:05 AM PST, Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote:
>The operstate of a networking device initially IF_OPER_UNKNOWN aka
>"unknown", updated on carrier state changes (with carrier state being
>on
>by default). This means it will stay unknown unless the carrier state
>goes to off at some point, which is not the case if the phy is already
>up/connected at startup.
Correct, drivers typically call netif_carrier_off prior to registering the network device to give a predictable link state, regardless of whether or not they use PHYLIB.
>
>Explicitly turn off the carrier on phy attach, leaving the phy state
>machine to turn the carrier on when it has done the initial
>negotiation.
Same comment as Andrew on the comment below.
Out of curiosity, was there a particular driver you ran into issues with?
--
Florian
next prev parent reply other threads:[~2016-01-13 1:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 18:44 [PATCH] net: phy: turn carrier off on phy attach Sjoerd Simons
2016-01-11 22:17 ` David Miller
2016-01-12 0:57 ` Andrew Lunn
2016-01-13 1:31 ` Florian Fainelli [this message]
2016-01-14 20:22 ` Sjoerd Simons
-- strict thread matches above, loose matches on Subject: below --
2016-01-14 20:57 Sjoerd Simons
2016-01-15 19:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10DF45FB-A812-4D6F-8B45-817B86FD48CE@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).