netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars Melin <larsm17@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>, johan@kernel.org, bjorn@mork.no
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	Matthew Garrett <mgarrett@aurora.tech>
Subject: Re: [PATCH 1/3] USB: serial: option: Add generic MDM9207 configurations
Date: Mon, 26 Dec 2022 08:23:34 +0700	[thread overview]
Message-ID: <10cff30a-719d-f6b0-419c-36c552f4bc4b@gmail.com> (raw)
In-Reply-To: <20221225205224.270787-2-mjg59@srcf.ucam.org>

On 12/26/2022 03:52, Matthew Garrett wrote:
> +	/* Qualcomm MDM9207 - 0: DIAG, 2: AT, 3: NMEA */
> +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf601),
> +	  .driver_info = RSVD(1) | RSVD(4) | RSVD(5) },
> +	/* Qualcomm MDM9207 - 2: DIAG, 4: AT, 5: NMEA */
> +	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0xf622),
> +	  .driver_info = RSVD(0) | RSVD(1) | RSVD(3) | RSVD(6) },

Please tell what the reserved interfaces are used for and why they 
should be blacklisted.
The generic Qualcomm driver for 05c6:f601 (which is used by at least one 
other brand/reseller) specifies that interface#1 is for USB Modem (ppp 
dial-up).
I assume that you posses this dongle since you add support for it so you 
can easily verify that function which I assume has not been disabled in 
your version.

thanks
Lars


  reply	other threads:[~2022-12-26  1:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 20:52 Add some USB hotspot IDs Matthew Garrett
2022-12-25 20:52 ` [PATCH 1/3] USB: serial: option: Add generic MDM9207 configurations Matthew Garrett
2022-12-26  1:23   ` Lars Melin [this message]
2022-12-26  2:08     ` Matthew Garrett
2022-12-26  2:43       ` Matthew Garrett
2022-12-26  5:38         ` Lars Melin
2022-12-25 20:52 ` [PATCH 2/3] net: usb: qmi_wwan: Add generic MDM9207 configuration Matthew Garrett
2022-12-25 20:52 ` [PATCH 3/3] USB: serial: option: Add Novatel MiFi 8800L diag endpoint Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10cff30a-719d-f6b0-419c-36c552f4bc4b@gmail.com \
    --to=larsm17@gmail.com \
    --cc=bjorn@mork.no \
    --cc=johan@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgarrett@aurora.tech \
    --cc=mjg59@srcf.ucam.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).