From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E0B14EF127 for ; Tue, 29 Sep 2026 09:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790672925; cv=none; b=Ma8qA8YK044RzgT5+uOa7DhtSVSgbMsqCvVMWzu0Al4dRv1BQ5NjepvAXAwvz9xdMVJFqjf26gH8zLQBfZnAqkksd3LlikRTENYeNH6lifKogr5aVCxvgyG9g75PAttF0kKyCMT5lCfOYKTxeGFvDZF/gzvFfmKtF7kKHacVmpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790672925; c=relaxed/simple; bh=ruJ+OC8TeuBbcfhTBYGa0RnK/itzn1qKU2Z9PqQpXyE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j/Jrl+FEbx13DeOGy1CXiwr3F2vDqlSgBN/yBxU9gCbdAIGSF1IfA46bxIrYxkvodg/GMuIF7I4GVVz/+sOcUMYN8WhRrayElfgwh0aTC8epwd0Fd236zd6RTeFZnc95Pyw9Zeau2lAcxFb/6Ye/reA7isnojTLGYQUbLtO5uQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=deC5XP0+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ORvyZlhK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="deC5XP0+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ORvyZlhK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790672917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K/tDQmq8LLYXlBRzwGWyXEcI6FT4qeqUihRf6IwcU/I=; b=deC5XP0+flxFisnNxniV6209R+cZPkgraqQH/0ss5kRzdrcj1QYm+WT5x5BLe84Ba9bi3k H65V5MPfqPl5iajPlqIXcAuFG/hyN/CVjr+mt4oxVVzSq/tNoLBo03Wcscl0EDnGbIJvgE r886jxjNuEBeYsHVjNJuOtKbUI/Sd0k= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-Ved390sVOxKymNfY_IwJUw-1; Tue, 29 Sep 2026 05:08:36 -0400 X-MC-Unique: Ved390sVOxKymNfY_IwJUw-1 X-Mimecast-MFC-AGG-ID: Ved390sVOxKymNfY_IwJUw_1790672915 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-49ff43a1ecbso22020175e9.1 for ; Tue, 29 Sep 2026 02:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790672915; x=1791277715; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=K/tDQmq8LLYXlBRzwGWyXEcI6FT4qeqUihRf6IwcU/I=; b=ORvyZlhKMqUmKvNXzg1BWoc2QBC/FMkf18vXY5+nZxI7iI5ECzEIRSzaT19fsi/3IK D0hRv07+lQU0c9jIuUb9Pv21hMIQIehnIR6yMmHZfI3DmXDhpl5Pb/lMjRDi3Nm5A4MM 2X0g0bvi7vvuCWDxneWJpHiG0qRmYwaS60bqYwCBuI3ZbHtRadRJ8qy1x3U9shJbzKWz hQb761DbNohgOLkLow6S1J4wwY16SGXGy0ZHFrh078rpcy96G/Fb6NskxSdQedgzvdD5 yjWbIeopYKpi0fkNnjFwwjTGMoL4S8MfITqLebCP2md/gOFygSgdYhz4jLhHJ0E2dB0H vHCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790672915; x=1791277715; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K/tDQmq8LLYXlBRzwGWyXEcI6FT4qeqUihRf6IwcU/I=; b=Bt6yAtKjF4Y00ZKx05MCeKKzup7t+l2t5BlVCAFjFRlGaDkTP4RKyb5WrSK3g0YjSl hzrxCD6L9WFJiiED3E0uXkeskDZs26pO0QgobrvrQw3yr6r7aU59VEJwQ6WvN+dkuL7i VOpN2Cr9/Jdi5xcdxxk7iTZb08xtPimUDkqNyfFRKq/94jKYLgG/Wd+Uh2fJW8yGw2Nm I9L6EqpY4f1DlwosRrUu80/lZ9PqQyuHDON42wfjGSuMB+/FgmavxaLiemiX4WK4Z98X SeGciYP49FrchKAV/OASuEZXimCpyUGKaCV+IiPthwWhtmXFk5/aOanHOos2erEXbYlB llHA== X-Forwarded-Encrypted: i=1; AKwUvBwIdZZwBYMiaL+fEy4IByOCPl91MLkRoKElJm2rHLD31lElakza4vmq40cRLZvGK1OUuTEpgDE=@vger.kernel.org X-Gm-Message-State: AFuF++nilaVLW90Tv4Z/wH1xJk0hwXt/6KZrUzYCM0pgiCXlIsqVWwbI ZL1MbGSd44dxzfRY2qHjIbRngiOpvxy66TGiYSqE22n84Ng/o/fnAria4E+H9KkNI9w5l8a8hHN BY591dZnO5SBVCyvdWdfygu9pDc6r2y8eh/eRqpW74x5CrwHkOvig7LLFNA== X-Gm-Gg: AYBFou1y5tPTJjZTCm7+JU7A4MPY3anPP829/w/GNkoSsDbfjRSD3TXh9I7zseLzUhA HURaJTKw4jcAjMeqPj5anhK/8PU/93NU82zfxj5CuRPPRx9IMWQ7ClABkhw9QJanTYtT7bzKwYp WcvEGjH5plYb5kNfmYzOtO/zmEKnGPuWPybL4VOnQcqDAP37m3XCGC/4cbv7qOm6bcssLxy6g9W NGa/GLhblK2LAXfzkrCSwTgAOvRJGrfY5d+pcCV07Wh7AT1z3zLd4nW8Z/F28ZHJXIm5CAmaI6E OrnF3Sof4OlJnfzWyEEM6IfwzlFrpTnqWgQAAqbQwynPZZwTJnYIgwAZkfDyj0bsdPLqMIZIMpe S6u5D0/Elwz7WjM8dEevJl/USoT9pECQ+DqpS6kAp5ph6V64CK3WKEPhlhSwgh1nLWBzFeWKZVA == X-Received: by 2002:a05:600c:3150:b0:49f:fd2d:23d1 with SMTP id 5b1f17b1804b1-49ffd2d2627mr138475405e9.27.1790672914985; Tue, 29 Sep 2026 02:08:34 -0700 (PDT) X-Received: by 2002:a05:600c:3150:b0:49f:fd2d:23d1 with SMTP id 5b1f17b1804b1-49ffd2d2627mr138475085e9.27.1790672914566; Tue, 29 Sep 2026 02:08:34 -0700 (PDT) Received: from [192.168.188.234] (ip232-47-231-195.pool-bba.aruba.it. [195.231.47.232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48af5080925sm2483598f8f.25.2026.09.29.02.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2026 02:08:34 -0700 (PDT) Message-ID: <10d0c5a6-98d0-45d5-a196-aa839b452172@redhat.com> Date: Tue, 29 Sep 2026 11:08:32 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 0/2] net: dsa: mt7530: fix trapped frame forwarding and egress tagging To: Tao Gong , netdev@vger.kernel.org Cc: "Chester A . Unal" , Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Matthias Brugger , AngeloGioacchino Del Regno , Lorenzo Bianconi , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Florian Fainelli , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20260923055103.949540-1-gongtao0607@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260923055103.949540-1-gongtao0607@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/23/26 07:51, Tao Gong wrote: > This series resolves two issues in the MT7530 DSA switch driver preventing > trapped link-local control frames (such as STP BPDUs) from reaching the CPU > host when bridge VLAN filtering is enabled: > > 1. Commit 3ac85bcfd404 ("net: dsa: mt7530: preserve VLAN tags on trapped > link-local frames") set MT7530_VLAN_EG_DISABLED to preserve VLAN tags, > but in hardware this disables the per-packet override and causes > trapped frames to follow the CPU port's active VLAN table (VAWD2) rule. > When bridge VLAN filtering is active, the CPU port is in stack mode, > causing incoming untagged BPDUs (01:80:C2:00:00:00) to be egressed with > a VLAN tag, which userspace STP daemons (such as ustpd) and the kernel > bridge drop. MT7530_VLAN_EG_CONSISTENT correctly preserves wire state > (untagged frames stay untagged, tagged frames stay tagged). > > 2. On Airoha EN7581 and AN7583 switch IP, setting MT7531_CFC (0x04) > CPU_PMAP alone is insufficient; the switch MAC forwarding control > (MT753X_MFC, 0x10) must also have CPU_EN and CPU_PORT configured for > trapped frames to exit to the CPU conduit. It's unclear to me if you are observing the issue with real H/W or if the patches comes from LLMs or static analysis. Please clarify such info in the next iteration. Also clashiko feedback looks relevant, please have a look. You should address LLM's feedback proactively. /P