From: Marek Vasut <marex@nabladev.com>
To: Fidelio Lawson <lawson.fidelio@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Marek Vasut <marex@denx.de>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Fidelio Lawson <fidelio.lawson@exotec.com>
Subject: Re: [PATCH v4 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata
Date: Fri, 17 Apr 2026 16:35:09 +0200 [thread overview]
Message-ID: <10e325c0-aeb0-47b1-b758-e4f47ff7b004@nabladev.com> (raw)
In-Reply-To: <20260417-ksz87xx_errata_low_loss_connections-v4-1-6c7044ec4363@exotec.com>
On 4/17/26 2:44 PM, Fidelio Lawson wrote:
[...]
> @@ -1271,6 +1287,29 @@ int ksz8_w_phy(struct ksz_device *dev, u16 phy, u16 reg, u16 val)
> if (ret)
> return ret;
> break;
> + case PHY_REG_KSZ87XX_SHORT_CABLE:
> + if (!ksz_is_ksz87xx(dev))
> + return -EOPNOTSUPP;
> + ret = ksz87xx_apply_low_loss_preset(dev, !!val);
> + if (ret)
> + return ret;
> + break;
> + case PHY_REG_KSZ87XX_LPF_BW:
> + if (!ksz_is_ksz87xx(dev))
> + return -EOPNOTSUPP;
> + ret = ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, (u8)val);
> + if (ret)
> + return ret;
> + dev->lpf_bw = val;
> + break;
> + case PHY_REG_KSZ87XX_EQ_INIT:
> + if (!ksz_is_ksz87xx(dev))
> + return -EOPNOTSUPP;
> + ret = ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, (u8)val);
Do these values need some check, so they would be in the correct
range(s) / in the correct bitfields before being written into those
registers ?
next prev parent reply other threads:[~2026-04-17 14:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 12:44 [PATCH v4 0/3] ksz87xx: add support for low-loss cable equalizer errata Fidelio Lawson
2026-04-17 12:44 ` [PATCH v4 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Fidelio Lawson
2026-04-17 14:35 ` Marek Vasut [this message]
2026-04-17 15:20 ` Fidelio LAWSON
2026-04-17 15:22 ` Marek Vasut
2026-04-17 15:50 ` [PATCH] fixup! " Fidelio Lawson
2026-04-17 16:10 ` Sai Krishna Gajula
2026-04-17 16:30 ` Fidelio LAWSON
2026-04-17 16:39 ` Fidelio Lawson
2026-04-17 12:44 ` [PATCH v4 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Fidelio Lawson
2026-04-17 12:44 ` [PATCH v4 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Fidelio Lawson
2026-04-17 14:36 ` [PATCH v4 0/3] ksz87xx: add support for low-loss cable equalizer errata Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e325c0-aeb0-47b1-b758-e4f47ff7b004@nabladev.com \
--to=marex@nabladev.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fidelio.lawson@exotec.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lawson.fidelio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox