From: Eric Dumazet <eric.dumazet@gmail.com>
To: Oliver Herms <oliver.peter.herms@gmail.com>,
David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: ip/tnl: Set iph->id only when don't fragment is not set
Date: Tue, 26 Nov 2019 14:45:48 -0800 [thread overview]
Message-ID: <10e81a17-6b38-3cfa-8bd2-04ff43a30541@gmail.com> (raw)
In-Reply-To: <4e964168-2c83-24bb-8e44-f5f47555e589@gmail.com>
On 11/26/19 11:10 AM, Oliver Herms wrote:
>
> What do you think about making this configurable via sysctl and make the current
> behavior the default? I would also like to make this configurable for other
> payload types like TCP and UDP. IMHO there the ID is unnecessary, too, when DF is set.
>
Certainly not.
I advise you to look at GRO layer (at various stages, depending on linux version)
You can not 'optimize [1]' the sender and break receivers ( including old ones )
[1] Look at ip_select_ident_segs() : the per-socket id generator makes
ID generation quite low cost, there is no real issue here.
next prev parent reply other threads:[~2019-11-26 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 13:24 [PATCH v2] net: ip/tnl: Set iph->id only when don't fragment is not set Oliver Herms
2019-11-25 22:41 ` David Miller
2019-11-26 19:10 ` Oliver Herms
2019-11-26 20:51 ` David Miller
2019-11-26 22:45 ` Eric Dumazet [this message]
2019-11-26 23:32 ` Oliver Herms
2019-11-27 0:23 ` Eric Dumazet
2019-11-27 0:28 ` Eric Dumazet
2019-11-27 12:19 ` Oliver Herms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10e81a17-6b38-3cfa-8bd2-04ff43a30541@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=oliver.peter.herms@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).