From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Christian Marangi" <ansuelsmth@gmail.com>
Subject: Re: [PATCH net-next 2/2] net: dsa: qca8k: consistently use "ret" rather than "err" for error codes
Date: Sat, 3 Feb 2024 17:26:14 +0100 [thread overview]
Message-ID: <10ec9fa5-208c-4318-9c8a-11297c7b3aa9@lunn.ch> (raw)
In-Reply-To: <20240202163626.2375079-3-vladimir.oltean@nxp.com>
On Fri, Feb 02, 2024 at 06:36:26PM +0200, Vladimir Oltean wrote:
> It was pointed out during the review [1] of commit 68e1010cda79 ("net:
> dsa: qca8k: put MDIO bus OF node on qca8k_mdio_register() failure") that
> the rest of the qca8k driver uses "int ret" rather than "int err".
>
> Make everything consistent in that regard, not only
> qca8k_mdio_register(), but also qca8k_setup_mdio_bus().
>
> [1] https://lore.kernel.org/netdev/qyl2w3ownx5q7363kqxib52j5htar4y6pkn7gen27rj45xr4on@pvy5agi6o2te/
>
> Suggested-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-02-03 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 16:36 [PATCH net-next 0/2] Fixups for qca8k ds->user_mii_bus cleanup Vladimir Oltean
2024-02-02 16:36 ` [PATCH net-next 1/2] net: dsa: qca8k: put MDIO controller OF node if unavailable Vladimir Oltean
2024-02-02 16:36 ` [PATCH net-next 2/2] net: dsa: qca8k: consistently use "ret" rather than "err" for error codes Vladimir Oltean
2024-02-03 16:26 ` Andrew Lunn [this message]
2024-02-03 16:30 ` Christian Marangi
2024-02-05 12:40 ` [PATCH net-next 0/2] Fixups for qca8k ds->user_mii_bus cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10ec9fa5-208c-4318-9c8a-11297c7b3aa9@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsi@bang-olufsen.dk \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).