linux-next build failure (was: Re: [PATCH/REPOST] pci: push deprecated pci_find_device() function to last user)

linux-next build failure (was: Re: [PATCH/REPOST] pci: push deprecated pci_find_device() function to last user)

[Geert Uytterhoeven]

On Fri, Jan 15, 2010 at 19:08, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> On Thu, 14 Jan 2010 23:18:41 +0100 (CET)
> Tilman Schmidt <tilman@imap.cc> wrote:
>
>> Am 14.01.2010 17:28 schrieb Jesse Barnes:
>> > I can take it, but I lost the original patch.  Tilman, can you
>> > resend?
>>
>> Sure, here you are:
>>
>> Subject: [PATCH] pci: push deprecated pci_find_device() function to
>> last user
>>
>> The ISDN4Linux HiSax driver family contains the last remaining users
>> of the deprecated pci_find_device() function. This patch creates a
>> private copy of that function in HiSax, and removes the now unused
>> global function together with its controlling configuration option,
>> CONFIG_PCI_LEGACY.
>>
>> Impact: code reorganization, no functional change
>> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
>> ---
>> Note: This patch is not, nor does it intend to be, checkpatch.pl
>> clean. The issues checkpatch.pl reports on it were already present
>> before, and are unrelated to the topic of this patch.
>
> Applied to my linux-next branch, thanks Tilman.

Just guessing: something's wrong if CONFIG_PCI is not set?

http://kisskb.ellerman.id.au/kisskb/buildresult/2042085/

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: linux-next build failure (was: Re: [PATCH/REPOST] pci: push deprecated pci_find_device() function to last user)

[Tilman Schmidt]

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

Am 18.01.2010 15:44 schrieb Geert Uytterhoeven:
> On Fri, Jan 15, 2010 at 19:08, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>> On Thu, 14 Jan 2010 23:18:41 +0100 (CET)
>> Tilman Schmidt <tilman@imap.cc> wrote:
>>>
>>> Subject: [PATCH] pci: push deprecated pci_find_device() function to
>>> last user
>>>
>>> The ISDN4Linux HiSax driver family contains the last remaining users
>>> of the deprecated pci_find_device() function. This patch creates a
>>> private copy of that function in HiSax, and removes the now unused
>>> global function together with its controlling configuration option,
>>> CONFIG_PCI_LEGACY.
>>>
>>> Impact: code reorganization, no functional change
>>> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
>>> ---
>>> Note: This patch is not, nor does it intend to be, checkpatch.pl
>>> clean. The issues checkpatch.pl reports on it were already present
>>> before, and are unrelated to the topic of this patch.
>>
>> Applied to my linux-next branch, thanks Tilman.
> 
> Just guessing: something's wrong if CONFIG_PCI is not set?
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/2042085/

Sorry, oversight of mine. I thought that hisax/avm_pci.c depended on
CONFIG_PCI, but it doesn't, as it also handles ISA PnP cards. I will
issue a corrected patch ASAP.

Thanks,
Tilman

-- 
Tilman Schmidt                    E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]