From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Colin Leroy <colin.lkml@colino.net>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, netdev@oss.sgi.com
Subject: Re: [(broken) PATCH] Sungem and wake_on_lan
Date: Thu, 11 Nov 2004 09:57:36 +1100 [thread overview]
Message-ID: <1100127457.25814.19.camel@gaston> (raw)
In-Reply-To: <20041109151154.43c897dd.colin.lkml@colino.net>
On Tue, 2004-11-09 at 15:11 +0100, Colin Leroy wrote:
> Hi everyone,
>
> I'm trying to implement wake_on_lan in sungem. I did it by mimicking the
> Darwin AppleGMACEthernet driver.
> I have some problems with it; not only it doesn't work (pinging the
> target machine does not wake it up, nor does ether-wake.c), but also the
> normal resume crashes instead of working - before powering screen up,
> so no log available...
>
> My laptop has a BCM5221 PHY, I suppose it supports WOL but did not
> check. Anyway it shouldn't crash on normal resume, as Darwin's driver
> doesn't seem to have special cases depending on PHYs.
>
> Before putting the laptop to sleep, I issue a 'sudo ethtool -s eth0 wol p'
> to enable gp->wake_on_lan.
>
> Here's the patch, in case anyone (BenH, David Miller ? :)) has an idea
> about something i do wrong.
> Thanks,
Not sure at this point why it would die, but I'm pretty sure you must
edit the PHY PM code too in sungem_phy.c to not shut it down :)
Darwin does have some special cases for PHYs.
Ben.
prev parent reply other threads:[~2004-11-10 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 14:11 [(broken) PATCH] Sungem and wake_on_lan Colin Leroy
2004-11-10 22:57 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1100127457.25814.19.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=colin.lkml@colino.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).