From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [(broken) PATCH] Sungem and wake_on_lan Date: Thu, 11 Nov 2004 09:57:36 +1100 Message-ID: <1100127457.25814.19.camel@gaston> References: <20041109151154.43c897dd.colin.lkml@colino.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Linux Kernel list , netdev@oss.sgi.com Return-path: To: Colin Leroy In-Reply-To: <20041109151154.43c897dd.colin.lkml@colino.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Tue, 2004-11-09 at 15:11 +0100, Colin Leroy wrote: > Hi everyone, > > I'm trying to implement wake_on_lan in sungem. I did it by mimicking the > Darwin AppleGMACEthernet driver. > I have some problems with it; not only it doesn't work (pinging the > target machine does not wake it up, nor does ether-wake.c), but also the > normal resume crashes instead of working - before powering screen up, > so no log available... > > My laptop has a BCM5221 PHY, I suppose it supports WOL but did not > check. Anyway it shouldn't crash on normal resume, as Darwin's driver > doesn't seem to have special cases depending on PHYs. > > Before putting the laptop to sleep, I issue a 'sudo ethtool -s eth0 wol p' > to enable gp->wake_on_lan. > > Here's the patch, in case anyone (BenH, David Miller ? :)) has an idea > about something i do wrong. > Thanks, Not sure at this point why it would die, but I'm pretty sure you must edit the PHY PM code too in sungem_phy.c to not shut it down :) Darwin does have some special cases for PHYs. Ben.