netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Vosburgh <jv@jvosburgh.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Wilder <wilder@us.ibm.com>,
	netdev@vger.kernel.org, pradeep@us.ibm.com, i.maximets@ovn.org,
	amorenoz@redhat.com, haliu@redhat.com,
	stephen@networkplumber.org, horms@kernel.org, pabeni@redhat.com,
	andrew+netdev@lunn.ch, edumazet@google.com, razor@blackwall.org,
	shuah@kernel.org, corbet@lwn.net,
	linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v14 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags.
Date: Fri, 24 Oct 2025 20:44:50 -0700	[thread overview]
Message-ID: <1102580.1761363890@famine> (raw)
In-Reply-To: <20251022175033.7daec7f6@kernel.org>

Jakub Kicinski <kuba@kernel.org> wrote:

>On Wed, 22 Oct 2025 11:25:27 -0700 David Wilder wrote:
>> The current implementation of the arp monitor builds a list of vlan-tags by
>> following the chain of net_devices above the bond. See bond_verify_device_path().
>> Unfortunately, with some configurations, this is not possible. One example is
>> when an ovs switch is configured above the bond.
>
>Once again if anyone thinks this belongs in the kernel please speak up.
>Otherwise let this be the last posting.
>
>*If* someone does speak up in support you will need to find a less ugly
>way to represent the attribute within Netlink. What you invent must work
>in YNL and be added to the spec (Documentation/netlink/specs/rt-link.yaml)
>-- 
>pw-bot: cr

	Sorry, didn't have a chance to catch up until now.  I gave this
a read through again, and I have mixed feelings about it.

	I understand the problem they're trying to solve, which is
largely an artifact of the way OVS kind of lives off to the side and
does its own thing.  And, yes, there are a bunch of other things (tc,
ebpf, et al) that can arbitrarily tweak VLAN tags in a packet.

	That said, it's kind of a niche use case, and it's adding what
feels to me like an awkward API and its related infrastructure that will
have to be maintained forever.  Bonding already has baggage from things
that seemed like a good idea at the time, but ultimately weren't, so I'm
reluctant to add something like this for a niche case.

	-J

---
	-Jay Vosburgh, jv@jvosburgh.net

  reply	other threads:[~2025-10-25  3:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 18:25 [PATCH net-next v14 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 1/7] bonding: Adding struct bond_arp_target David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 2/7] bonding: Adding extra_len field to struct bond_opt_value David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 3/7] bonding: arp_ip_target helpers David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 4/7] bonding: Processing extended arp_ip_target from user space David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 5/7] bonding: Update to bond_arp_send_all() to use supplied vlan tags David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 6/7] bonding: Update for extended arp_ip_target format David Wilder
2025-10-22 18:25 ` [PATCH net-next v14 7/7] bonding: Selftest and documentation for the arp_ip_target parameter David Wilder
2025-10-23  0:50 ` [PATCH net-next v14 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags Jakub Kicinski
2025-10-25  3:44   ` Jay Vosburgh [this message]
2025-11-12  6:44   ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1102580.1761363890@famine \
    --to=jv@jvosburgh.net \
    --cc=amorenoz@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=corbet@lwn.net \
    --cc=edumazet@google.com \
    --cc=haliu@redhat.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pradeep@us.ibm.com \
    --cc=razor@blackwall.org \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=wilder@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).