From: Marcel Holtmann <marcel@holtmann.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
bluez-devel@lists.sf.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Network Development Mailing List <netdev@oss.sgi.com>
Subject: Re: [2.6 patch] net/bluetooth/: misc possible cleanups
Date: Tue, 14 Dec 2004 08:34:08 +0100 [thread overview]
Message-ID: <1103009649.2143.65.camel@pegasus> (raw)
In-Reply-To: <20041214041352.GZ23151@stusta.de>
Hi Adrian,
> The patch below contains the following possible cleanups:
> - make needlessly global code static
> - remove the following EXPORT_SYMBOL'ed but unused functions in
> hci_core.c:
> - hci_suspend_dev
> - hci_resume_dev
> - hci_register_cb
> - hci_unregister_cb
these functions must stay. They have users outside the mainline kernel
that are not merged back yet. Otherwise they won't be exported ;)
> Please comment on which of these changes are correct and which conflict
> with pending patches.
Please send a separate patch for all the RFCOMM changes, because these
conflicts with some pending patches and then it will make it easier for
me to merge them.
The rest of the changes are fine with me, but I like to see also a
separate patch for the CMTP stuff and cmtp_send_capimsg() don't need a
forward declaration. Simply move the function to another place in the
source code.
Regards
Marcel
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
next prev parent reply other threads:[~2004-12-14 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-14 4:13 [2.6 patch] net/bluetooth/: misc possible cleanups Adrian Bunk
2004-12-14 7:34 ` Marcel Holtmann [this message]
2004-12-14 9:45 ` Christoph Hellwig
2004-12-14 9:54 ` Marcel Holtmann
2004-12-19 16:07 ` Adrian Bunk
2004-12-19 16:13 ` [2.6 patch] bluetooth/rfcomm/: make some code static Adrian Bunk
2004-12-19 16:34 ` [2.6 patch] bluetooth/cmtp/capi.c: make a function static Adrian Bunk
2004-12-19 16:34 ` [2.6 patch] bluetooth: make some code static Adrian Bunk
2004-12-26 11:20 ` [2.6 patch] net/bluetooth/: misc possible cleanups Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103009649.2143.65.camel@pegasus \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sf.net \
--cc=bluez-devel@lists.sourceforge.net \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).