From: Yanteng Si <si.yanteng@linux.dev>
To: Xiangqian Zhang <zhangxiangqian@kylinos.cn>, andrew+netdev@lunn.ch
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mii: Fix the Speed display when the network cable is not connected
Date: Thu, 16 Jan 2025 09:42:16 +0800 [thread overview]
Message-ID: <11039148-82ea-4dea-8734-47eabdb268ef@linux.dev> (raw)
In-Reply-To: <20250115111805.3894377-1-zhangxiangqian@kylinos.cn>
在 2025/1/15 19:18, Xiangqian Zhang 写道:
> Two different models of usb card, the drivers are r8152 and asix. If no
> network cable is connected, Speed = 10Mb/s. This problem is repeated in
> linux 3.10, 4.19, and 5.4. Both drivers call
> mii_ethtool_get_link_ksettings, but the value of cmd->base.speed in this
> function can only be SPEED_1000 or SPEED_100 or SPEED_10.
> When the network cable is not connected, set cmd->base.speed
> =SPEED_UNKNOWN.
>
> v2:
> https://lore.kernel.org/20250111132242.3327654-1-zhangxiangqian@kylinos.cn
So, you've already sent a v2. This patch should be sent as v3.
Also, the link to v2 should not be included in the commit message.
Instead, it should be placed here:
---
v2:
https://lore.kernel.org/20250111132242.3327654-1-zhangxiangqian@kylinos.cn
drivers/net/mii.c | 3 +++
1 file changed, 3 insertions(+)
Thanks,
Yanteng
next prev parent reply other threads:[~2025-01-16 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 11:18 [PATCH] net: mii: Fix the Speed display when the network cable is not connected Xiangqian Zhang
2025-01-16 1:42 ` Yanteng Si [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-10 9:03 Xiangqian Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11039148-82ea-4dea-8734-47eabdb268ef@linux.dev \
--to=si.yanteng@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangxiangqian@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).