Problem with "ESP: sha1 digestsize 20 != 0"

Problem with "ESP: sha1 digestsize 20 != 0"

[Marcel Holtmann]

Hi,

when using my RAS account with 2.6.11-rc3, I see a lot of

	ESP: sha1 digestsize 20 != 0

messages in my logs and the IPsec tunnel is not working. I tracked the
problem down to the change below. After reverting this patch, everything
works like before.

Regards

Marcel


ChangeSet@1.1830.738.7, 2005-01-25 21:53:42-08:00, herbert@gondor.apana.org.au
  [XFRM]: Probe selected algorithm only.
  
  This patch removes an annoying problem in xfrm_user.  As it is every
  time an SA is added it probes every known algorithm in the universe.
  Now if they all existed it would be OK.  However, for the ones which
  don't actually exist this causes multiple /sbin/modprobe processes to
  be spawned which slows the system down when you're adding hundreds of
  SAs.
  
  Since we know the type of algorithm required when we're adding a new
  SA, we can get away with only probing the selected algorithms.  This
  is what the following patch does for xfrm_user.

Re: Problem with "ESP: sha1 digestsize 20 != 0"

[Herbert Xu]

Marcel Holtmann <marcel@holtmann.org> wrote:
> 
> when using my RAS account with 2.6.11-rc3, I see a lot of
> 
> 	ESP: sha1 digestsize 20 != 0
> 
> messages in my logs and the IPsec tunnel is not working. I tracked the
> problem down to the change below. After reverting this patch, everything
> works like before.

Sorry, my fault.

The name test in xfrm_get_byname is inverted.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
===== net/xfrm/xfrm_algo.c 1.16 vs edited =====
--- 1.16/net/xfrm/xfrm_algo.c	2005-01-26 16:53:19 +11:00
+++ edited/net/xfrm/xfrm_algo.c	2005-02-04 07:38:16 +11:00
@@ -357,7 +357,7 @@
 		return NULL;
 
 	for (i = 0; i < entries; i++) {
-		if (!strcmp(name, list[i].name))
+		if (strcmp(name, list[i].name))
 			continue;
 
 		if (list[i].available)

Re: Problem with "ESP: sha1 digestsize 20 != 0"

[Marcel Holtmann]

Hi Herbert,

> > when using my RAS account with 2.6.11-rc3, I see a lot of
> > 
> > 	ESP: sha1 digestsize 20 != 0
> > 
> > messages in my logs and the IPsec tunnel is not working. I tracked the
> > problem down to the change below. After reverting this patch, everything
> > works like before.
> 
> Sorry, my fault.
> 
> The name test in xfrm_get_byname is inverted.

now it is working again. Thanks.

Regards

Marcel

Re: Problem with "ESP: sha1 digestsize 20 != 0"

[David S. Miller]

On Fri, 04 Feb 2005 07:39:38 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> Marcel Holtmann <marcel@holtmann.org> wrote:
> > 
> > when using my RAS account with 2.6.11-rc3, I see a lot of
> > 
> > 	ESP: sha1 digestsize 20 != 0
> > 
> > messages in my logs and the IPsec tunnel is not working. I tracked the
> > problem down to the change below. After reverting this patch, everything
> > works like before.
> 
> Sorry, my fault.
> 
> The name test in xfrm_get_byname is inverted.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks Herbert.