netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Yusupov <dima@neterion.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Mike Christie <mikenc@us.ibm.com>, Jens Axboe <axboe@suse.de>,
	Christoph Hellwig <hch@infradead.org>,
	James Bottomley <James.Bottomley@SteelEye.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	netdev@oss.sgi.com, open-iscsi@googlegroups.com
Subject: Re: iSCSI and scatterlists
Date: Wed, 16 Mar 2005 11:59:42 -0800	[thread overview]
Message-ID: <1111003182.27052.46.camel@beastie> (raw)
In-Reply-To: <20050316185310.GQ21986@parcelfarce.linux.theplanet.co.uk>

On Wed, 2005-03-16 at 18:53 +0000, Matthew Wilcox wrote:
> On Wed, Mar 16, 2005 at 10:44:50AM -0800, Mike Christie wrote:
> > I got lost here. If you are talking about the need to kmap a sglist then 
> > software iscsi has it. iscsi-sfnet used to do
> > 
> > while (...)
> > 	kmap()
> > 
> > but I fixed that (I think I need to use kmap_atomic though, is that 
> > correct or is it just a performance improvement - I am calling kmap from 
> > a thread too so). I just added kmap_atomic to open-iscsi and I believe 
> > pyx does something similar to the loop above.
> 
> Sounds like networking should grow an interface to accept a sglist as
> input.  I'm really not familiar with Linux's networking stack to know
> how to do it ... cc'ing netdev to get their thoughts.

This is a nice idea, but will not always work with iSCSI protocol simply
because iSCSI PDU's data sizes might be negotiated to be lesser/bigger
than original WRITE's sglist size. It might help to optimize some data
path when PDU's data segment size >= sglist size. i.e. entire sglist
needs to be passed down to the stack.

i'm cross-posting to open-iscsi mailing list, so open-iscsi folks might
participate in the discussion.

Dmitry

      reply	other threads:[~2005-03-16 19:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200503160209.j2G29cAf010870@hera.kernel.org>
     [not found] ` <20050316075839.GC7842@suse.de>
     [not found]   ` <1110986016.5771.3.camel@mulgrave>
     [not found]     ` <20050316160447.GU7842@suse.de>
     [not found]       ` <20050316164806.GO21986@parcelfarce.linux.theplanet.co.uk>
     [not found]         ` <20050316165338.GX7842@suse.de>
     [not found]           ` <20050316170259.GA25056@infradead.org>
     [not found]             ` <20050316170417.GY7842@suse.de>
     [not found]               ` <42387EA2.5020106@us.ibm.com>
2005-03-16 18:53                 ` iSCSI and scatterlists Matthew Wilcox
2005-03-16 19:59                   ` Dmitry Yusupov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111003182.27052.46.camel@beastie \
    --to=dima@neterion.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=axboe@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mikenc@us.ibm.com \
    --cc=netdev@oss.sgi.com \
    --cc=open-iscsi@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).