netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: "David S. Miller" <davem@davemloft.net>,
	Network Development Mailing List <netdev@oss.sgi.com>
Subject: Re: [NET] make all protos partially use sk_prot
Date: Sat, 26 Mar 2005 14:09:01 +0100	[thread overview]
Message-ID: <1111842541.9195.183.camel@pegasus> (raw)
In-Reply-To: <20050326003937.GA13951@conectiva.com.br>

Hi Arnaldo,

> 	Please take a look and apply if acceptable, full description is
> on the changeset.
> 
> 	Ah, I started using __ as a separator between class name and
> method, I've been using this in some client projects and find it useful
> for grepping and for ctags, as it eliminates some false positives and
> do namespacing more strongly, please tell me if you don't like it.
> 
> 	If this is accepted the next changesets probably will move
> struct proto and the proto__ routines to net/core/prot.{c,h} and I'll
> add proto__ prefix to all struct proto members, etc.

I personally don't like the __ separator thing. Is this really needed?
What is wrong with using "proto_register()"? Where is the advantage?

And please don't convert from using "err" to "rc" for the return value
of the init function. In the case of the Bluetooth subsystem we never
call these variables "rc" and thus you are messing things up.

Regards

Marcel

  reply	other threads:[~2005-03-26 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-26  0:39 [NET] make all protos partially use sk_prot Arnaldo Carvalho de Melo
2005-03-26 13:09 ` Marcel Holtmann [this message]
2005-03-26 13:13   ` Arnaldo Carvalho de Melo
2005-03-26 13:15     ` Arnaldo Carvalho de Melo
2005-03-26 13:36       ` Marcel Holtmann
2005-03-26 13:42         ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1111842541.9195.183.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=acme@ghostprotocols.net \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).