Re: take 2 WAS(Re: PATCH: IPSEC xfrm events

[jamal <hadi@cyberus.ca>]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Masahide,

Attached is incremental patch on top of the one posted earlier.
Looks ok from my basic testing. Please run it against your tests
and see if it stands.

cheers,
jamal

On Sun, 2005-04-03 at 11:47, Patrick McHardy wrote:
> You call these functions from both softirq- and user-context, so you
> need to protect against BHs.
> 
> Regards
> Patrick
> 

[-- Attachment #2: ipsec-event-take2-1-1 --]
[-- Type: text/plain, Size: 704 bytes --]

--- a/net/xfrm/xfrm_state.c	2005/04/03 16:30:31	1.2
+++ b/net/xfrm/xfrm_state.c	2005/04/03 16:31:27
@@ -251,20 +251,20 @@
 {
 	struct xfrm_mgr *km;
 
-	read_lock(&xfrm_km_lock);
+	read_lock_bh(&xfrm_km_lock);
 	list_for_each_entry(km, &xfrm_km_list, list)
 		if (km->notify_policy)
 			km->notify_policy(xp, dir, c);
-	read_unlock(&xfrm_km_lock);
+	read_unlock_bh(&xfrm_km_lock);
 }
 
 void km_state_notify(struct xfrm_state *x, struct km_event *c)
 {
 	struct xfrm_mgr *km;
-	read_lock(&xfrm_km_lock);
+	read_lock_bh(&xfrm_km_lock);
 	list_for_each_entry(km, &xfrm_km_list, list)
 		km->notify(x, c);
-	read_unlock(&xfrm_km_lock);
+	read_unlock_bh(&xfrm_km_lock);
 }
 
 EXPORT_SYMBOL(km_policy_notify);