From: Dmitry Yusupov <dmitry_yus@yahoo.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
netdev@oss.sgi.com, davem@davemloft.net
Subject: Re: [PATCH] NETLINK_UESTABLISHED notifier event
Date: Thu, 07 Apr 2005 16:36:41 -0700 [thread overview]
Message-ID: <1112917001.3893.77.camel@beastie> (raw)
In-Reply-To: <20050407213231.GA28738@gondor.apana.org.au>
On Fri, 2005-04-08 at 07:32 +1000, Herbert Xu wrote:
> On Wed, Apr 06, 2005 at 03:26:25PM -0700, Dmitry Yusupov wrote:
> >
> > Messages from kernel are asynchronous and there are no alloc_skb on "up"
> > calls. It is "mempooled out" on interface level. (see Open-iSCSI
> > interface). Messages to kernel requires copy_from_user to newly
> > allocated skb, here is where we need sk_allocation bit set. Those
> > messages are synchronous from daemon perspective. If "down" call fails,
> > we will re-try later or take some other management action. We assuming
> > that later OOM-killer will free some memory for us and atomic allocation
> > will succeed eventually.
>
> I presume you only need to send one message at a time of a fixed size.
> Would it better to always have an skb allocated for the socket so that
> we don't need to allocate at sendmsg time?
This actually even better since we will guarantee "down" call delivery.
My only concern is that it is not very generic. Do you know clean way to
implement it?
next prev parent reply other threads:[~2005-04-07 23:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 19:54 [PATCH] NETLINK_UESTABLISHED notifier event Dmitry Yusupov
2005-04-05 21:39 ` Jean-Mickael Guerin
2005-04-05 23:53 ` Dmitry Yusupov
2005-04-06 0:13 ` Dmitry Yusupov
2005-04-06 2:45 ` Herbert Xu
2005-04-06 5:55 ` Dmitry Yusupov
2005-04-06 6:03 ` Herbert Xu
2005-04-06 15:16 ` Dmitry Yusupov
2005-04-06 16:23 ` Mike Christie
2005-04-06 21:29 ` Herbert Xu
2005-04-06 21:37 ` Dmitry Yusupov
2005-04-06 22:04 ` Herbert Xu
2005-04-06 22:26 ` Dmitry Yusupov
2005-04-07 11:30 ` jamal
2005-04-07 15:05 ` Dmitry Yusupov
2005-04-07 21:32 ` Herbert Xu
2005-04-07 23:36 ` Dmitry Yusupov [this message]
2005-04-08 11:36 ` Herbert Xu
2005-04-08 15:30 ` Dmitry Yusupov
2005-04-09 1:44 ` Herbert Xu
2005-04-09 16:02 ` Dmitry Yusupov
2005-04-09 19:36 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112917001.3893.77.camel@beastie \
--to=dmitry_yus@yahoo.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).